From 1398b2cddb88b57f23b1f3c5d48e2ae23577a963 Mon Sep 17 00:00:00 2001 From: bado Date: Tue, 5 Nov 2024 12:29:02 +0800 Subject: [PATCH] ci(check-ci-skip): fix commitMessagesMetadata.forEach is not a function Primary Changes ---------------- 1. Added condition to commitMessagesMetadata to check if commit message is array or not. Fixes #3614 Signed-off-by: bado --- tools/ci-skip-for-maintainers.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/ci-skip-for-maintainers.js b/tools/ci-skip-for-maintainers.js index 911c637ca4..31bd60aad3 100644 --- a/tools/ci-skip-for-maintainers.js +++ b/tools/ci-skip-for-maintainers.js @@ -33,10 +33,14 @@ const main = async () => { pullReqUrl + "/commits", ); - commitMessagesMetadata.forEach((commitMessageMetadata) => { - // get commit message body - commitMessageList.push(commitMessageMetadata["commit"]["message"]); - }); + if (Array.isArray(commitMessagesMetadata)) { + commitMessagesMetadata.forEach((commitMessageMetadata) => { + // get commit message body + commitMessageList.push(commitMessageMetadata["commit"]["message"]); + }); + } else { + console.error("Commit message data is empty or null"); + } // Check if skip-ci is found in commit message const checkSkipCI = () => {