Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Reexport aead defined types used in the ursa public API #195

Open
mversic opened this issue Dec 5, 2021 · 1 comment
Open

Reexport aead defined types used in the ursa public API #195

mversic opened this issue Dec 5, 2021 · 1 comment
Assignees
Labels
possibly-irrelevant We anticipate this will not be a concern in the near future

Comments

@mversic
Copy link

mversic commented Dec 5, 2021

Description of the problem:

ursa lib depends on aead and uses aead defined types in it's public API like here. This forces the user to depend on aead in their Cargo.toml even though they make no use of aead itself except through ursa. Forcing users to manage dependency of a dependency is a malpractice.

Solution

Either reexport entire aead liib from ursa or reexport just aead types that are exposed in the public API of ursa. In the given example that would be either pub export aead or pub export aead::Error. Type aliases are also welcome

@brentzundel brentzundel added the possibly-irrelevant We anticipate this will not be a concern in the near future label Feb 1, 2023
@appetrosyan
Copy link
Contributor

Should be addressed in either #225 or a follow-up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
possibly-irrelevant We anticipate this will not be a concern in the near future
Development

No branches or pull requests

3 participants