Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Keep extra fields of termsOfUse of VC in a map. #586

Closed
kdimak opened this issue Oct 25, 2019 · 1 comment · Fixed by #621
Closed

Keep extra fields of termsOfUse of VC in a map. #586

kdimak opened this issue Oct 25, 2019 · 1 comment · Fixed by #621
Assignees
@kdimak
Labels
refactor
Milestone
0.1.1

Comments

@kdimak
Copy link
Contributor

kdimak commented Oct 25, 2019

Currently we use interface{} type for termsOfUse what is too generic. According to VC spec, type field is mandatory and id field is optional, and that "precise contents of each term of use is determined by the specific termsOfUse type definition".
We should use 'typedID' type and keep extra fields in map[string]interface{}.
@kdimak kdimak mentioned this issue Oct 25, 2019
Merged
@troyronda troyronda added this to the 0.1.1 milestone Oct 25, 2019
@kdimak kdimak mentioned this issue Oct 29, 2019
Merged
@llorllale
Copy link
Contributor

@kdimak

We should use 'typedID' type and keep extra fields in map[string]interface{}.

Would it make sense to instead implement a "decoder" similar to verifiable.CredentialDecoder?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdimak kdimak

Labels
refactor
Milestone
0.1.1
Development

Successfully merging a pull request may close this issue.

refactor: Keep extra fields of termsOfUse of VC in a map kdimak/aries-framework-go
3 participants
@troyronda @llorllale @kdimak