Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Move JWE crypter crypto operations under wallet #385

Closed
Moopli opened this issue Oct 1, 2019 · 1 comment · Fixed by #459
Closed

Move JWE crypter crypto operations under wallet #385

Moopli opened this issue Oct 1, 2019 · 1 comment · Fixed by #459
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Moopli
Copy link
Contributor

Moopli commented Oct 1, 2019

To ensure the wallet maintains control over secrets, the crypto operations in Crypters need to be inside the wallet. However, the formatting of envelopes doesn't conceptually belong to the wallet, and Crypters/Packers should instead ask the wallet to compute crypto operations needed for pack/unpack.

This issue is for refactoring the JWE Authcrypter.

Part of #36

@fqutishat fqutishat added the enhancement New feature or request label Oct 1, 2019
@fqutishat fqutishat added this to the 0.1.0 milestone Oct 1, 2019
@baha-ai
Copy link
Contributor

baha-ai commented Oct 9, 2019

Follow up:

Since the formatting of the envelope is tightly intertwined with the encryption, the logic for formatting will be kept in the crypter.

The wallet should only handle manipulation of keys (especially the private keys) within its boundary.

therefore, operations that deal with private keys should be moved to the wallet. It has been found that only DeriveKEK is manipulating private keys and so it will be moved to the wallet.

Pack/Unpack message functions will be moved from the wallet to their own envelope packager under Packager interface.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants