-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OKX wallet / explicitly surface Keplr errors #85
Comments
I tested this with the latest wagmi/rainbowkit (branch off #89) and I don't see any errors. It's possible this issues was fixed in a recent update. |
Reopening to further investigate OKX issues |
I've done some more testing with OKX mixed with other wallets in Chrome:
So TLDR, I can confirm OKX is willing to masquerade as another wallet but I can't repro the exact issue the user saw. It's possible that some users are clicking the Keplr option without realizing they don't have it installed, causing it to actually connect to OKX instead. AFAI can tell, there is no way to differentiate from Metamask/Keplr vs OKX when OKX is impersonating those other wallets. I'm testing with the latest version of all extensions. Maybe this bug requires an older version. In terms of next steps, if I can't get any a reproduction of the bug, I don't think I can look for workarounds. We could try UX solutions, like forcing a confirmation modal for the user to accept. Finally, I'll just add that the Warp UI is not the only DApp feeling this pain. There's an EIP that Pedro from WalletConnect has been leading which alleviates it but wallets must each buy-in: https://twitter.com/pedrouid/status/1765822163829862589 |
Someone in Discord was having intermittent issues with Keplr wallet. They also had the OKX wallet installed. Sometimes when trying to connect to Keplr, the OKX wallet would silently take precedence. The addresses in the side panel would relate to the OKX wallet addresses despite saying "Keplr" on them. We should:
Context
The text was updated successfully, but these errors were encountered: