feat(router): Add missing unimplemented fallback to RoutesBuilder #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Aug 9, 2024
tonic/src/service/router.rs
Outdated
| impl Default for Routes { | ||
| fn default() -> Self { | ||
| let router = axum::Router::new().fallback(unimplemented); | ||
| Self { router } |
There was a problem hiding this comment.
Suggest inlining the router binding directly.
tottoto
force-pushed
the
add-missing-unimplemented-fallback-to-routesbuilder
branch
from
c810d83 to
d6d2806
Compare
tottoto
deleted the
add-missing-unimplemented-fallback-to-routesbuilder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing unimplemented fallback routing when constructing
RoutesviaRoutes::defaultorRoutesBuilder.