Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tonic-build): cargo build script outputs are not functional #1821

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

d3rpp
Copy link
Contributor

@d3rpp d3rpp commented Jul 25, 2024

Motivation

I was looking through and debugging some services and noticed that the println!() statements in the tonic-build crate were not correctly formatted.

Example 1:

println!("cargo:rerun-if-changed={}", path.as_ref().display())

Example 2:

println!("cargo:rerun-if-changed={}", path.as_ref().display())

They all have a single : when they should have 2 as shown in the cargo book:

https://doc.rust-lang.org/cargo/reference/build-scripts.html#rerun-if-changed

Solution

Just added the extra :, did a full workspace search to ensure I got all of them 👍


If there's anything else you'd like me to do to properly follow any requirements please let met know 😄

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc djc added this pull request to the merge queue Jul 25, 2024
Merged via the queue into hyperium:master with commit dfd3bb4 Jul 25, 2024
16 checks passed
tottoto added a commit that referenced this pull request Aug 28, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants