Update tokio dependencies in tutorials to be compatible with tonic 0.4 #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
approved these changes
Feb 2, 2021
Bumps routeguide tutorial dependency to tokio 1.0 for compatability with tonic 0.4. Also adds required rt-multi-thread feature and drops unused and now unsupported stream feature. Signed-off-by: hasheddan <[email protected]>
hasheddan
force-pushed
the
tokio-helloworld
branch
from
cb7ad66 to
d9895bb
Compare
|
@LucioFranco should be ready now :) I just dropped the helloworld update because it looks like another PR got in already that fixed it 👍 |
This was referenced Mar 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The existing tutorials do not build due to incompatibility of tonic 0.4 and tokio 0.2.
Solution
Update tokio dependencies to 1.0 and adjust required features accordinly.
Thanks for the awesome work y'all do on this library!