feat(transport): Make service router independent from transport #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
changed the title
tottoto
force-pushed
the
router-feature
branch
from
08aa8fe to
f4eba36
Compare
tottoto
force-pushed
the
router-feature
branch
3 times, most recently
from
24f6cf8 to
8506612
Compare
tottoto
force-pushed
the
router-feature
branch
2 times, most recently
from
7dc3707 to
e9a5713
Compare
tottoto
force-pushed
the
router-feature
branch
2 times, most recently
from
0945556 to
6847a34
Compare
djc
reviewed
May 21, 2024
tonic/src/transport/service/mod.rs
Outdated
| pub use self::router::Routes; | ||
| pub use self::router::RoutesBuilder; | ||
| /// A deprecated re-export. Please use `tonic::service::{Routes, RoutesBuilder}` directly. | ||
| pub use crate::service::{Routes, RoutesBuilder}; |
There was a problem hiding this comment.
Should we put #[deprecated] on these deprecated re-exports? Why/why not?
There was a problem hiding this comment.
This is because of the limitation of #[deprecated].
|
Added a change which makes |
tottoto
force-pushed
the
router-feature
branch
3 times, most recently
from
ab3dbc3 to
b419bb2
Compare
17 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to use the service router independent from transport feature.