Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): make test_module of header! optional #492

Merged
merged 1 commit into from
May 1, 2015

Conversation

seanmonstar
Copy link
Member

Closes #490

/cc @pyfisch @maximih

@pyfisch
Copy link
Contributor

pyfisch commented May 1, 2015

👍 but you should not make deref! private.

@seanmonstar
Copy link
Member Author

Oh Woops, that was me experimenting.

On Fri, May 1, 2015, 1:33 AM Pyfisch [email protected] wrote:

[image: 👍] but you should not make deref! private.


Reply to this email directly or view it on GitHub
#492 (comment).

@seanmonstar seanmonstar force-pushed the header-macro-example branch from 2c7b682 to a5ce9c5 Compare May 1, 2015 21:27
seanmonstar added a commit that referenced this pull request May 1, 2015
fix(header): make test_module of header! optional
@seanmonstar seanmonstar merged commit 6d7ae81 into master May 1, 2015
@seanmonstar seanmonstar deleted the header-macro-example branch May 1, 2015 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in the header! macro not documented
2 participants