feat(lib): change custom executors to be Fn
#2015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of custom executors needing to be `tokio::Executor` or `tokio::TypedExecutor`, they are now just `Fn`s. BREAKING CHANGE: Configuring an `executor` for a client or server should now pass a closure or function to spawn the future. Closes #1944
LucioFranco
approved these changes
Nov 15, 2019
|
A closure frequently couldn't be used since the executor needed to be able to be passed different future types. New solution in #2032 |
|
@seanmonstar btw that points to the same PR? |
|
Woops, fixed XD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of custom executors needing to be
tokio::Executorortokio::TypedExecutor, they are now justFns.BREAKING CHANGE: Configuring an
executorfor a client or server shouldnow pass a closure or function to spawn the future.
Closes #1944