Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer-Encoding: identity #2058

Closed
m0ppers opened this issue Dec 9, 2019 · 1 comment · Fixed by #2075
Closed

Transfer-Encoding: identity #2058

m0ppers opened this issue Dec 9, 2019 · 1 comment · Fixed by #2075
Labels
A-http1 Area: HTTP/1 specific. C-bug Category: bug. Something is wrong. This is bad! E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@m0ppers
Copy link

m0ppers commented Dec 9, 2019

I have a web service that returns its content with "Transfer-Encoding: identity". If I read the spec correctly that means that the content should not be touched and interpreted as it is.

Unfortunately hyper seems to assume that whenever transfer encoding is present in a response header it interprets the content as if it would be chunked.

I modified the following line locally to CLOSE_DELIMITED and now it works for me (tm)

https://github.com/hyperium/hyper/blob/0.12.x/src/proto/h1/role.rs#L768

interestingly the code comment doesn't really match the actual code. not sure what the background of this is.

@seanmonstar
Copy link
Member

Yep, that line looks wrong indeed!

@seanmonstar seanmonstar added A-http1 Area: HTTP/1 specific. E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-bug Category: bug. Something is wrong. This is bad! labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-http1 Area: HTTP/1 specific. C-bug Category: bug. Something is wrong. This is bad! E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants