Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sender regression in hyper 0.12.35 #1954

Closed
Demi-Marie opened this issue Sep 26, 2019 · 3 comments
Closed

Sender regression in hyper 0.12.35 #1954

Demi-Marie opened this issue Sep 26, 2019 · 3 comments

Comments

@Demi-Marie
Copy link

See paritytech/substrate#3685 for details.
@seanmonstar
Copy link
Member

Would you mind explaining what behavior change you've noticed? I can't find in that repo the referenced test case.

@seanmonstar
Copy link
Member

As described in this comment, I don't think this is a regression in the Sender, but rather the consequences of a bug fix around GET chunked bodies.

@Demi-Marie
Copy link
Author

For anyone else who finds this, Substrate was trying to send a body on a GET request that didn’t have one. #1926 made the Substrate bug visible, but it had been there before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanmonstar @Demi-Marie