Refactor hypercert page data loading #319
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bigger PR than planned, but a quite fundamental change...
This PR updates the loading of the hypercert page to not be a single call to the Graph, but split calls for hypercert data, evaluations and marketplace listings.
The single page layout of the page has been split into multiple components with suspense boundaries, enabling the partial loading of related data and improvind readability. To follow the RSC pattern, the hypercert page is loaded async with different segments wrapped in suspense boundaries.
Additionally, when a mutation is executed the cache for both profile and the hypercert page are invalidated. For example, instead of passing the full object of an hypercert through all components, we now simply use the available hypercertId when available.
While refactoring I tried to harmosize some flows and for example standardized the ErrorState component to a global component.
A few focus points for the review: