Skip to content
This repository has been archived by the owner on May 27, 2023. It is now read-only.

Null response without an error #4

Open
GoldenGamerLP opened this issue Jan 7, 2022 · 20 comments
Open

Null response without an error #4

GoldenGamerLP opened this issue Jan 7, 2022 · 20 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@GoldenGamerLP
Copy link

Describe the bug
So when you trying to load up a schematic via Scaffolding.fromFile or via the FileInputStream the response is always null. There is no exception too which would be thrown. BTW my entire completeable future is beeing closed but i have no idea what why and whats caused it...

To Reproduce
Steps to reproduce the behavior:

  1. Load up a schematic
  2. look via if(schematic != null) if its null
  3. Use it in a CompleteableFuture
  4. See null response with no error (Schematics are tested and worked fine)

Expected behavior
It should throw an error and should load when the schematics are right, load them up.

Screenshots
1.
image
2. (Debug)
image
(- Please ask for a full code snippet)

Desktop (please complete the following information):

  • Latest Scaffolding version
  • Latest Minestom verison (Not 1.18 branch)
  • Java 17
@LooFifteen
Copy link
Member

What kind of schematic are you using? MCEdit or Sponge?

@GoldenGamerLP
Copy link
Author

I tried both types and also renamed them both to .schematic

@LooFifteen
Copy link
Member

Are you able to send a screenshot of the schematic open in NBTExplorer?

@GoldenGamerLP
Copy link
Author

GoldenGamerLP commented Jan 7, 2022

  1. Schematic:
    image
  2. Schematic:
    image
  • Not NBT explorer sorry, i cant install it rn

@LooFifteen
Copy link
Member

Schematic 1 is a Sponge schematic, try loading it using new SpongeSchematic()#read. I don't recognise the second one, are you able to send the file for me to check out tomorrow?

@GoldenGamerLP
Copy link
Author

Yes the first one is Sponge, the second one had a .nbt thing at the end. Ill try the new SpongeSchematic()#read later. Thanks

@GoldenGamerLP
Copy link
Author

GoldenGamerLP commented Jan 7, 2022

So i created the Schematic by myself but it didnt work either

image

@LooFifteen
Copy link
Member

How exactly did you know it didn't work?

@GoldenGamerLP
Copy link
Author

How exactly did you know it didn't work?

When I read the nbt via fileinputstream, it caused my whole completable future to exit und stop working, even my debug messages after the loop wouldn't print out.

@LooFifteen
Copy link
Member

I will need the schematics to reproduce this.

@GoldenGamerLP
Copy link
Author

Yes, i downloaded a random schematic, here it is: https://workupload.com/file/RNfUqkkMXZc

@GoldenGamerLP
Copy link
Author

So i tried reading the NBT data myself and this error occoured with this code:
Error:

image

Code to reproduce:

image

@LooFifteen LooFifteen added bug Something isn't working good first issue Good for newcomers labels Jan 9, 2022
@LooFifteen
Copy link
Member

Okay, I'll look into this sometime tomorrow.

@GoldenGamerLP
Copy link
Author

Thanks ^^

@LooFifteen
Copy link
Member

The schematic you provided has loaded on my machine, but the block palette is slightly off.

@GoldenGamerLP
Copy link
Author

Ah okay, I have no more ideas why it isn't loading and exiting my whole completable furutre. Do you maybe have an idea where the error which I send you is coming from?

@LooFifteen
Copy link
Member

It may be caused by the fact you are not on the 1.18 branch of Minestom.

@GoldenGamerLP
Copy link
Author

That could be true, I'm using the latest version of the main branch (-SNAPSHOT)

@GoldenGamerLP
Copy link
Author

Any news on the bug?

@LooFifteen
Copy link
Member

I'm not sure, I was able to read and build the schematic perfectly fine. I did discover a different bug but it was unrelated to your issue.

@joshuasing joshuasing added this to the v0.2 milestone Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants