Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First day of week in week format does not work correctly #170

Closed
kliyer-ai opened this issue Oct 30, 2019 · 3 comments · Fixed by #204
Closed

First day of week in week format does not work correctly #170

kliyer-ai opened this issue Oct 30, 2019 · 3 comments · Fixed by #204
Labels
need to investigate

Comments

@kliyer-ai
Copy link
Contributor

kliyer-ai commented Oct 30, 2019 •
edited
Loading

Version of flutter_calendar_carousel

flutter_calendar_carousel: ^1.4.2

Expected behavior

When I set the firstDayOfWeek property to a number larger than zero, the weekdays and the actual dates get shifted according.

Actual behavior

Only the weekdays get shifted.

Correct

true

With firstDayOfWeek set to 1 (not correct)

false

flutter doctor result (run flutter doctor in terminal)

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.9.1+hotfix.5, on Linux, locale en_US.UTF-8)
 
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Android Studio (version 3.4)
[✓] Connected device (1 available)

• No issues found!

Steps to reproduce the behavior

Set weekFormat to true

Set firstDayOfWeek to 1
@hyochan
Copy link
Owner

hyochan commented Nov 2, 2019

firstDayOfWeek feature isn't supported in weekBuilder currently. Waiting for contributor!

@kliyer-ai
Copy link
Contributor Author

Could you provide me with some pointers where I could look to fix this issue? Thanks!

@kliyer-ai kliyer-ai mentioned this issue Feb 13, 2020
Merged
@halldorlogi
Copy link

Screenshot 2020-02-21 at 12 40 38

Fixed it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need to investigate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add first day of week offset to week builder kliyer-ai/flutter_calendar_carousel
3 participants
@kliyer-ai @hyochan @halldorlogi