Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stdlib 'wrapping' doesn't pass positional args to the stdlib logger #19

Closed
gcbirzan opened this issue Dec 1, 2013 · 0 comments
Closed

Stdlib 'wrapping' doesn't pass positional args to the stdlib logger #19

gcbirzan opened this issue Dec 1, 2013 · 0 comments
Labels
stdlib

Comments

@gcbirzan
Copy link
Contributor

gcbirzan commented Dec 1, 2013

This is used (by us, anyway), extensively, because we just like pain. But, even so, it should be supported.
gcbirzan added a commit to gcbirzan/structlog that referenced this issue Dec 1, 2013
@gcbirzan
hynek#19 Pass positional arguments down to stdlib
23a1eab
gcbirzan added a commit to gcbirzan/structlog that referenced this issue Dec 16, 2013
@gcbirzan
hynek#19 Pass positional arguments down to stdlib
dde8347
gcbirzan added a commit to gcbirzan/structlog that referenced this issue Jun 11, 2014
@gcbirzan
Fix hynek#19 Pass positional arguments down to stdlib
d0dfc32
gcbirzan added a commit to gcbirzan/structlog that referenced this issue Jun 14, 2014
@gcbirzan
Fix hynek#19 Pass positional arguments down to stdlib
1493856
emfree added a commit to nylas/sync-engine that referenced this issue Jul 14, 2014
@emfree
Adapt logging setup to work when the API server is run under gunicorn.
fe647af 
Summary:
Run with:
  gunicorn --worker-class inbox.api.wsgi.InboxWSGIWorker --logger-class inbox.api.wsgi.GunicornLogger inbox.api.srv:app ...

This also requires some minor changes to our existing logging setup, because
gunicorn passes positional arguments in its logging messages
(`self.log.info('message %s', some_value)`) but structlog can't currently
handle that (hynek/structlog#19).

Test Plan:
Run `bin/inbox-api` and `gunicorn --worker-class
inbox.api.wsgi.InboxWSGIWorker --logger-class inbox.api.wsgi.GunicornLogger
--workers=1 --bind 127.0.0.1:5555 inbox.api.srv:app` and make some API
requests.

Reviewers: spang

Reviewed By: spang

Differential Revision: https://review.inboxapp.com/D235
emfree added a commit to nylas/sync-engine that referenced this issue Jul 14, 2014
@emfree @spang
Adapt logging setup to work when the API server is run under gunicorn.
a36adad 
Summary:
Run with:
  gunicorn --worker-class inbox.api.wsgi.InboxWSGIWorker --logger-class inbox.api.wsgi.GunicornLogger inbox.api.srv:app ...

This also requires some minor changes to our existing logging setup, because
gunicorn passes positional arguments in its logging messages
(`self.log.info('message %s', some_value)`) but structlog can't currently
handle that (hynek/structlog#19).

Test Plan:
Run `bin/inbox-api` and `gunicorn --worker-class
inbox.api.wsgi.InboxWSGIWorker --logger-class inbox.api.wsgi.GunicornLogger
--workers=1 --bind 127.0.0.1:5555 inbox.api.srv:app` and make some API
requests.

Reviewers: spang

Reviewed By: spang

Differential Revision: https://review.inboxapp.com/D235
@hynek hynek added the stdlib label Oct 28, 2014
lakshmi-kannan pushed a commit to lakshmi-kannan/structlog that referenced this issue Nov 6, 2014
@gcbirzan
Fix hynek#19 Pass positional arguments down to stdlib
2efa99e
lakshmi-kannan pushed a commit to lakshmi-kannan/structlog that referenced this issue Nov 6, 2014
@gcbirzan
Fix hynek#19 Pass positional arguments down to stdlib
843500f
@wbolster wbolster mentioned this issue Jan 14, 2015
Merged
@hynek hynek closed this as completed in 438fce3 Jan 15, 2015
@wbolster wbolster mentioned this issue Jan 21, 2015
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hynek @gcbirzan