Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to print full namespace of module for CallsiteParameterAdder #492

Open
macintacos opened this issue Feb 15, 2023 · 3 comments

Comments

@macintacos
Copy link

macintacos commented Feb 15, 2023

When using CallsiteParameter.MODULE in CallsiteParameterAdder, it's a bit too vague for my tastes - for example, a module named config has no meaning unless I know what package it's referring to. For example, I may have a module called foo.bar.config and another package could have a module called baz.buz.config, and it would not be possible to tell the difference with that value currently.

I know that there's CallsiteParameter.PATHNAME, but that's overly verbose - although I guess I could transform it to be something more palatable... At the end of the day though, it would be nice if there was a CallsiteParameter that would just print out foo.bar.config.

@hynek
Copy link
Owner

hynek commented Mar 10, 2023

Those values and behavior are based on stdlib logging – how do they handle it?

@pahrohfit
Copy link
Contributor

Those values and behavior are based on stdlib logging – how do they handle it?

poorly.

zero tolerance for deviation or extension. I have a patch for this (new provider), but waiting for my last pull because I'm sometimes lazy and potentially forgot to branch.

@pahrohfit
Copy link
Contributor

I couldn't find an easy/transportable way to add it as a CallsiteParameterAdder, but I was able to toss it into a small processor #568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants