Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional_ignores in StackInfoRenderer #396

Closed
zionsofer opened this issue Jan 24, 2022 · 0 comments
Closed

Support additional_ignores in StackInfoRenderer #396

zionsofer opened this issue Jan 24, 2022 · 0 comments

Comments

@zionsofer
Copy link

zionsofer commented Jan 24, 2022

The stack info renderer is very useful to add stack traces, but unfortunately it keeps the traces of the actual logging itself.
In the funciton _find_first_app_frame_and_name there is support for finding the first relevant frame by adding ignored modules to be skipped, but this isn't exposed to the StackInfoRenderer in any way.
Since we have our internal logging mechanism built upon structlog, it would be very benficial if we could add this module prefix to the skipped modules.
If it were added as a parameter when initializing the class, for example, we could define ignored modules and get a more refined and less noisy stack trace.

@hynek hynek closed this as completed in 60792bc Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant