Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode/rust-analyzer plugin for better integration/highlighting/mermaid #273

Closed
MingweiSamuel opened this issue Dec 5, 2022 · 5 comments
Closed

VSCode/rust-analyzer plugin for better integration/highlighting/mermaid #273

MingweiSamuel opened this issue Dec 5, 2022 · 5 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hydroflow syntax Hydroflow's custom surface syntax

Comments

@MingweiSamuel
Copy link
Member

MingweiSamuel commented Dec 5, 2022 •
edited
Loading

  • Make it easier to view the mermaid graph inside the rust source code.
  • Better intellisense inside of the hydroflow syntax
  • Hydroflow syntax highlighting
  • Same for modular hydroflow files modular import of hydroflow graphs #220
@MingweiSamuel MingweiSamuel added documentation Improvements or additions to documentation enhancement New feature or request hydroflow syntax Hydroflow's custom surface syntax labels Dec 5, 2022
@MingweiSamuel
Copy link
Member Author

Look into rust-lang/rust-analyzer#5389

@MingweiSamuel
Copy link
Member Author

@jhellerstein #340

Would be cool to support @shadaj 's live mermaid generation inside VSCode. Possibly follow the approach used here? https://www.osohq.com/post/building-vs-code-extension-with-rust-wasm-typescript.

Would this also be a good way to improve intellisense for Hydroflow??

@MingweiSamuel MingweiSamuel mentioned this issue Jan 17, 2023
Closed
@MingweiSamuel MingweiSamuel changed the title Look into better integration/highlighting with rust-analyzer VSCode/rust-analyzer plugin for better integration/highlighting Jan 17, 2023
@MingweiSamuel MingweiSamuel changed the title VSCode/rust-analyzer plugin for better integration/highlighting VSCode/rust-analyzer plugin for better integration/highlighting/mermaid Jan 17, 2023
@MingweiSamuel
Copy link
Member Author

cargo check-tip is interesting as well:
https://www.reddit.com/r/rust/comments/10qgksm/media_ann_cargochecktip_add_tips_to_rust_errors/

@MingweiSamuel MingweiSamuel added the good first issue Good for newcomers label Mar 26, 2024
@MingweiSamuel
Copy link
Member Author

HF+ @shadaj #973

If we can hook into Rust Analyzer's logic for proc macro expansion, we should be able to inspect the generated sources and extract the JSON defining the Hydroflow graph, and then display it in the editor.

@MingweiSamuel MingweiSamuel mentioned this issue Mar 26, 2024
Closed
@MingweiSamuel
Copy link
Member Author

Attention moved to HF+, which supports code completion more natively.

@MingweiSamuel MingweiSamuel closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hydroflow syntax Hydroflow's custom surface syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MingweiSamuel