Skip to content
This repository has been archived by the owner on Aug 10, 2019. It is now read-only.

Enable non-sink functions within a DAG to write to KVS #106

Open
cw75 opened this issue May 1, 2019 · 5 comments
Open

Enable non-sink functions within a DAG to write to KVS #106

cw75 opened this issue May 1, 2019 · 5 comments
Labels
design Architectural issue

Comments

@cw75
Copy link
Contributor

cw75 commented May 1, 2019

No description provided.

@cw75 cw75 added the design Architectural issue label May 1, 2019
@vsreekanti
Copy link
Member

This is already possible. The only thing we have to change to enable this is to have the client library instrument reads/writes to track causal dependencies. Everything else already works.

@cw75
Copy link
Contributor Author

cw75 commented May 1, 2019

The client should also be able to specify which function in the DAG want to write the result to KVS and what's the name of output key.

@vsreekanti
Copy link
Member

How is that any different from calling fluent.put(key, val)?

@cw75
Copy link
Contributor Author

cw75 commented May 1, 2019

I think letting users embed these calls into functions is fine. Maybe we should just do this: by default the result of a func is only passed to downstream funcs, but if users want it to also write to kvs, then they need to explicitly write fluent.put(key, val) inside the func.

@vsreekanti
Copy link
Member

Yes, that's how it works right now. That's what I meant when I said the only thing that we needed to change was adding support for causal dependencies.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design Architectural issue
Projects
None yet
Development

No branches or pull requests

2 participants