Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetson(PWM): fix set period #1019

Merged
merged 1 commit into from
Oct 28, 2023
Merged

jetson(PWM): fix set period #1019

merged 1 commit into from
Oct 28, 2023
+3 −3

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Oct 28, 2023 •
edited
Loading

Solved issues and/or description of the change

SetPeriod() uses the value from the backing field and therefor not change the real value - changed to usage of the given parameter

in addition activate related tests

obsoletes the #990 , the honor go to @Jwen98

Manual test

none

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review October 28, 2023 11:57
@gen2thomas gen2thomas merged commit 991af9a into hybridgroup:dev Oct 28, 2023
1 check passed
@gen2thomas gen2thomas deleted the fix/jetson_pwm branch October 28, 2023 11:57
@gen2thomas gen2thomas mentioned this pull request Oct 28, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gen2thomas