-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Axios, replace with Fetch #863
Comments
We use this version because it's the same version used by openai sdk, see #816 (comment) We do try to use |
hmmm. this is making it very hard to use with nestjs which needs |
Well but it'd be exactly as hard to use the |
I am using latest Here is the relevant part from {
"dependencies": {
"axios": "^1.3.4",
"openai": "^3.2.1",
}
} |
(That would be because In any case I've opened PR #973 relaxing the peer dependency range for axios to make you folks happy (but I still recommend you use the axios version your dependencies (like openai) require, even if |
That |
Ah, right, just noticed it was under |
Same issue here. |
@tecoad the PR mentioned above was released in 0.0.64 id suggest updating |
Right now langchainjs is using a very old version of Axios. This requires us to npm install --legacy-peer-deps
Fetch is now supported in Node natively, which means the same interface will work on backend or frontend without the axios dependency. Since there are just a couple of uses of axios, and it will keep the project more terse, I would like to make a PR that removes the dependency on Axios and replaces it with native fetch. Can polyfill node-fetch for older clients as well.
If this is agreed to, I can make a PR and verify the tests.
The text was updated successfully, but these errors were encountered: