Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work with Gatsby 5 #110

Open
choffa opened this issue Nov 22, 2022 · 12 comments
Open

Update to work with Gatsby 5 #110

choffa opened this issue Nov 22, 2022 · 12 comments

Comments

@choffa
Copy link

choffa commented Nov 22, 2022

Currently installing this plugin without using --legacy-peer-deps fails when using gatsby@>=5.0.0.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/gatsby
npm ERR!   gatsby@"^5.1.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer gatsby@"^3.0.0 || ^4.0.0" from [email protected]
npm ERR! node_modules/gatsby-theme-material-ui
npm ERR!   gatsby-theme-material-ui@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/christopher/.npm/_logs/2022-11-22T19_48_06_169Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/christopher/.npm/_logs/2022-11-22T19_48_06_169Z-debug-0.log

I am not familiar enough with the plugin or gatsby to say if code needs to be updated or only the peer dependency definition...

@deekshasharma
Copy link

We are getting this warning when trying to install gatsby-plugin-material-ui with gatsby 5.0.0

Plugin gatsby-plugin-material-ui is not compatible with your gatsby version 5.0.0 - It requires gatsby@^3.0.0 || ^4.0.0

@yolomep
Copy link

yolomep commented Nov 29, 2022

For now, the latest version of gatsby-plugin-material-ui seems to work with gatsby v5 for most components.

@kdichev
Copy link

kdichev commented Dec 31, 2022

seems like there is a PR implementing the changes already #111 by @blackspherefollower
@hupe1980 can we get that in so we can update to latest Gatsby versions in our apps?

warn Plugin gatsby-theme-material-ui-top-layout is not compatible with your gatsby version 5.3.3 - It requires gatsby@^3.0.0 || ^4.0.0
warn Plugin gatsby-plugin-material-ui is not compatible with your gatsby version 5.3.3 - It requires gatsby@^3.0.0 || ^4.0.0
warn Plugin gatsby-theme-material-ui is not compatible with your gatsby version 5.3.3 - It requires gatsby@^3.0.0 || ^4.0.0
warn Plugin gatsby-theme-material-ui-top-layout is not compatible with your gatsby version 5.3.3 - It requires gatsby@^3.0.0 || ^4.0.0
warn Plugin gatsby-plugin-material-ui is not compatible with your gatsby version 5.3.3 - It requires gatsby@^3.0.0 || ^4.0.0
warn Plugin gatsby-theme-material-ui is not compatible with your gatsby version 5.3.3 - It requires gatsby@^3.0.0 || ^4.0.0

@jcpinillos
Copy link

Is there any update on when we could be expecting this plugin to work with Gatsby 5? Like kdichev was asking 3 weeks ago, there seems to be a fix in place.

@blackspherefollower
Copy link

FYI, I published my fork (just the Gatsby 5 change in the PR) as https://www.npmjs.com/package/@iostindex/gatsby-plugin-material-ui as a temporary solution

@Marco-Daniel
Copy link

Also ran into this issue today starting a new project. Any update on when it will work with Gatsby 5?

@guicompeng
Copy link

I also want to start a new project, any updates?

@shalupova-a
Copy link

would be nice to get a status update on this.

@Console32
Copy link

@hupe1980 Any chance to get some maintainers on board for this? I would offer to engage.

@kdichev
Copy link

kdichev commented Nov 2, 2023

@hupe1980 Any chance to get some maintainers on board for this? I would offer to engage.

he is MIA I've tried contacting him on multiple platforms to either give access to other maintainers or give the repo to somebody else

@blackspherefollower
Copy link

FWIW: I'll keep my fork up-to-date for as long as I'm using it

@guicompeng
Copy link

MUI updated the example and it is possible to use Gatsby 5 and MUI without this plugin: https://github.com/mui/material-ui/tree/master/examples/material-ui-gatsby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants