feat: error on bad type export

src/lint.ts

@@ -2,13 +2,23 @@ import path from 'path'
 import { parseExports } from './exports'
 import { logger } from './logger'
 import { PackageMetadata } from './types'
-import { hasCjsExtension, isESModulePackage } from './utils'
+import { hasCjsExtension, isESModulePackage, isTypeFile } from './utils'
 
 type BadExportItem = {
   value: boolean
   paths: string[]
 }
 
+function validateTypesFieldCondition(pair: [string, string]) {
+  const [outputPath, composedExportType] = pair
+  const exportTypes = new Set(composedExportType.split('.'))
+
+  if (!exportTypes.has('types') && isTypeFile(outputPath)) {
+    return true
+  }
+  return false
+}
+
 export function lint(pkg: PackageMetadata) {
   const { name, main, exports } = pkg
   const isESM = isESModulePackage(pkg.type)
@@ -26,6 +36,7 @@ export function lint(pkg: PackageMetadata) {
     badCjsImportExport: BadExportItem
     badEsmRequireExport: BadExportItem
     badEsmImportExport: BadExportItem
+    badTypesExport: [string, string][]
   } = {
     badMainExtension: false,
     badMainExport: false,
@@ -46,6 +57,7 @@ export function lint(pkg: PackageMetadata) {
       value: false,
       paths: [],
     },
+    badTypesExport: [],
   }
 
   // Validate ESM package
@@ -59,7 +71,12 @@ export function lint(pkg: PackageMetadata) {
         state.invalidExportsFieldType = true
       } else {
         parsedExports.forEach((outputPairs) => {
-          for (const [outputPath, composedExportType] of outputPairs) {
+          for (const outputPair of outputPairs) {
+            const [outputPath, composedExportType] = outputPair
+            if (validateTypesFieldCondition([outputPath, composedExportType])) {
+              state.badTypesExport.push([outputPath, composedExportType])
+            }
+
             const exportTypes = new Set(composedExportType.split('.'))
             let requirePath: string = ''
             let importPath: string = ''
@@ -97,7 +114,11 @@ export function lint(pkg: PackageMetadata) {
         state.invalidExportsFieldType = true
       } else {
         parsedExports.forEach((outputPairs) => {
-          for (const [outputPath, composedExportType] of outputPairs) {
+          for (const outputPair of outputPairs) {
+            const [outputPath, composedExportType] = outputPair
+            if (validateTypesFieldCondition([outputPath, composedExportType])) {
+              state.badTypesExport.push([outputPath, composedExportType])
+            }
             const exportTypes = new Set(composedExportType.split('.'))
             let requirePath: string = ''
             let importPath: string = ''
@@ -179,4 +200,13 @@ export function lint(pkg: PackageMetadata) {
       logger.warn(`  ${p}`)
     })
   }
+
+  if (state.badTypesExport.length) {
+    state.badTypesExport.forEach(([outputPath, composedExportType]) => {
+      logger.error(
+        `Bad export types field with ${composedExportType} in ${outputPath}, use "types" export condition for it`,
+      )
+    })
+    process.exit(1)
+  }
 }

src/plugins/output-state-plugin.ts

@@ -9,7 +9,7 @@ import {
   getSpecialExportTypeFromComposedExportPath,
   normalizeExportPath,
 } from '../entries'
-import { isBinExportPath } from '../utils'
+import { isBinExportPath, isTypeFile } from '../utils'
 
 // [filename, sourceFileName, size]
 type FileState = [string, string, number]
@@ -91,14 +91,6 @@ function createOutputState({ entries }: { entries: Entries }): {
   }
 }
 
-function isTypeFile(filename: string) {
-  return (
-    filename.endsWith('.d.ts') ||
-    filename.endsWith('.d.mts') ||
-    filename.endsWith('.d.cts')
-  )
-}
-
 function normalizeExportName(exportName: string): string {
   const isBinary = isBinExportPath(exportName)
   let result = exportName

src/utils.ts

@@ -226,3 +226,11 @@ export async function removeOutputDir(output: OutputOptions, cwd: string) {
 export function isBinExportPath(exportPath: string) {
   return exportPath === BINARY_TAG || exportPath.startsWith(BINARY_TAG + '/')
 }
+
+export function isTypeFile(filename: string) {
+  return (
+    filename.endsWith('.d.ts') ||
+    filename.endsWith('.d.mts') ||
+    filename.endsWith('.d.cts')
+  )
+}

test/integration/js-bad-configured-types/index.test.ts

@@ -0,0 +1,21 @@
+import { createIntegrationTest } from '../utils'
+
+describe('integration js-bad-configured-types', () => {
+  it('should error when types is not correctly configured', async () => {
+    await createIntegrationTest(
+      {
+        directory: __dirname,
+      },
+      async ({ stderr, code }) => {
+        expect(code).toBe(1)
+
+        expect(stderr).toContain(
+          `Bad export types field with import.require in ./dist/index.d.mts, use "types" export condition for it`,
+        )
+        expect(stderr).toContain(
+          `Bad export types field with require in ./dist/index.d.ts, use "types" export condition for it`,
+        )
+      },
+    )
+  })
+})

test/integration/js-bad-configured-types/package.json

@@ -0,0 +1,15 @@
+{
+  "types": "./dist/index.d.ts",
+  "exports": {
+    ".": {
+      "import": {
+        "require": "./dist/index.d.mts",
+        "default": "./dist/index.mjs"
+      },
+      "require": {
+        "require": "./dist/index.d.ts",
+        "default": "./dist/index.js"
+      }
+    }
+  }
+}

test/integration/js-bad-configured-types/src/index.js

@@ -0,0 +1,3 @@
+export function foo() {
+  return 'foo'
+}