Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Shared code auto code split #429

Closed
huozhi opened this issue Jan 25, 2024 · 1 comment · Fixed by #480
Closed

[RFC] Shared code auto code split #429

huozhi opened this issue Jan 25, 2024 · 1 comment · Fixed by #480

Comments

@huozhi
Copy link
Owner

huozhi commented Jan 25, 2024

Feedback from users

In the case where I want to share internal modules but not export them from the package, this doesn't work. I see each entry has its own rollup config defined, which would prevent rollup from handling these common chunks on its own. Have you thought about using a single config with separate input declarations for each entry? I would guess that maybe this would allow rollup to handle the common modules on its own.

Need to design a solution for shared modules that doesn't have to go to shared inputs

@huozhi huozhi changed the title [Feature Request] Shared code auto code split [RFC] Shared code auto code split Mar 4, 2024
@huozhi
Copy link
Owner Author

huozhi commented Mar 4, 2024

💡 : How about make a convention like xxx.shared.js and make it code split into its own part? But I don't know what the downside would be, feels like potential could mis-use it or conflicts with sth else. Want to have a pretty special one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant