Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several suggestions #31

Open
newpavlov opened this issue Aug 30, 2016 · 0 comments
Open

Several suggestions #31

newpavlov opened this issue Aug 30, 2016 · 0 comments

Comments

@newpavlov
Copy link

newpavlov commented Aug 30, 2016

Currently I am playing with rust-crypto and one of things I am trying to do is to replace bundled simd.rs with this crate. Based on it I have several suggestions:

  • Make struct fields (u32x4 and others) public. I don't see a reason why they should be private, while public fields make it noticeably easier to work with them.
  • Make sixty_four structs public. It's imported into lib.rs but left private.
  • Implement Shr and Shl (and probably other ops) traits for for u32x4 and other structs.
  • If possible make crate use no_std. As far as I can see outside of examples only mem and ops used and none of vec, boxes or other std specific stuff.
  • Implement or derive PartialEq and Eq for structs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant