Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components with circular dependency breaks HMR #1281

Closed
sacrosanctic opened this issue Sep 24, 2024 · 1 comment · May be fixed by #1182
Closed

Components with circular dependency breaks HMR #1281

sacrosanctic opened this issue Sep 24, 2024 · 1 comment · May be fixed by #1182

Comments

@sacrosanctic
Copy link

Describe the bug

If HMR is handled but it is within a circular dependency, a full reload will also happen to recover the execution order
https://vitejs.dev/guide/troubleshooting.html#a-full-reload-happens-instead-of-hmr

For example, the button component has a circular dependency.

Reproduction

.

Logs

No response

System Info

.

Severity

annoyance
@huntabyte huntabyte mentioned this issue Oct 9, 2024
Draft
3 tasks
@huntabyte
Copy link
Owner

Fixed in @next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

next: Svelte 5 huntabyte/shadcn-svelte
2 participants
@sacrosanctic @huntabyte