Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox doesn't include hidden input #1134

Closed
gtm-nayan opened this issue Jun 10, 2024 · 2 comments · May be fixed by #1182
Closed

Checkbox doesn't include hidden input #1134

gtm-nayan opened this issue Jun 10, 2024 · 2 comments · May be fixed by #1182

Comments

@gtm-nayan
Copy link

Describe the bug

The checkbox component only shows the indicator button and doesn't render the hidden input which means the checkbox doesn't show up in form submissions unless you manually bind the value and render it in another hidden checkbox

Reproduction

https://stackblitz.com/edit/github-ofar7n?file=src%2Froutes%2F%2Bpage.svelte,src%2Froutes%2F%2Bpage.server.ts

Logs

No response

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @sveltejs/kit: ^2.0.0 => 2.5.2 
    bits-ui: ^0.18.2 => 0.18.2 
    cmdk-sv: ^0.0.13 => 0.0.13 
    formsnap: ^0.5.0 => 0.5.0 
    lucide-svelte: ^0.303.0 => 0.303.0 
    mode-watcher: ^0.2.1 => 0.2.1 
    svelte: ^4.2.9 => 4.2.9 
    svelte-sonner: ^0.3.18 => 0.3.18 
    sveltekit-superforms: ^2.5.0 => 2.5.0 
    vaul-svelte: ^0.2.4 => 0.2.4

Severity

annoyance

@dyc3
Copy link

dyc3 commented Sep 25, 2024

I'd like to contribute a fix for this. Should I make a PR for this repo or bits-ui?

@huntabyte huntabyte mentioned this issue Sep 28, 2024
3 tasks
@huntabyte
Copy link
Owner

Fixed in @next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants