Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isVisible is not an exported Prop of Pagination.Item #1077

Closed
Carlos-err406 opened this issue May 6, 2024 · 8 comments · May be fixed by #1182
Closed

isVisible is not an exported Prop of Pagination.Item #1077

Carlos-err406 opened this issue May 6, 2024 · 8 comments · May be fixed by #1182
Labels
type: documentation A change or addition to the documentation

Comments

@Carlos-err406
Copy link
Contributor

Change Type

Correction

Proposed Changes

see here the usage section of the pagination docs

but the isVisible prop from Pagination.Item does not exist, since the props of this component are actually HTMLAttributes<HTMLLIElement>, see below for current implementation
image

here a copy/paste from the docs showing the error
image

my suggestion is to replace isVisible for hidden

@Carlos-err406 Carlos-err406 added the type: documentation A change or addition to the documentation label May 6, 2024
@Carlos-err406
Copy link
Contributor Author

i could open a PR for this

@huntabyte
Copy link
Owner

Hey @Carlos-err406, let me investigate this a bit to see where the disconnect is here before opening a PR!

@Carlos-err406
Copy link
Contributor Author

sure!

@jdgamble555
Copy link

I just came across this error. The examples are incorrect on the main site. Should this be there?

@huntabyte huntabyte mentioned this issue Sep 28, 2024
3 tasks
@huntabyte
Copy link
Owner

Fixed in shadcn-svelte@next / bits-ui@next

@kallaviktor
Copy link

Fixed in shadcn-svelte@next / bits-ui@next

I'm still getting this error using shadcn-svelte@next / bits-ui@next + sample code from the next docs.

@baderj
Copy link

baderj commented Nov 22, 2024

I'm also getting the error for this line of the pagination sample code:

<Pagination.Item isVisible={currentPage === page.value}>

Error: Object literal may only specify known properties, and '"isVisible"' does not exist in type 'HTMLLiAttributes & { ref?: HTMLElement | null | undefined; }'

Using

  • bits-ui: "1.0.0-next.63"
  • shadcn-svelte: "1.0.0-next.3"

@benjaminschreck
Copy link

I also get the same error using

bits-ui: "1.0.0-next.65"
shadcn-svelte: "1.0.0-next.4"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A change or addition to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants