Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: unexpected non-nested multiple popovers can be open at once #784

Closed
huntabyte opened this issue Oct 18, 2024 · 1 comment
Closed

Comments

@huntabyte
Copy link
Owner

huntabyte commented Oct 18, 2024

Describe the bug

CleanShot.2024-10-18.at.19.49.31.mp4

I know exactly why this is happening. Because we supported nested popovers, dialogs, etc., that can each be portable to the body and essentially act as siblings, we close things in the order they are open if one is opened before another is closed.

We can solve this specific issue, but it breaks the nested use cases which is quite annoying. This is going to be trickier than I initially thought.

Will need to think on this one for a bit.

Core Issue

  • We need to determine if an "interact outside event" occurred outside of the nested tree, rather than just occurring at all.

Reproduction

https://next.shadcn-svelte.com/docs/examples/task

Logs

No response

System Info

System:
    OS: macOS 15.0
    CPU: (12) arm64 Apple M2 Max
    Memory: 138.03 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.15.1 - ~/.nvm/versions/node/v20.15.1/bin/node
    npm: 10.7.0 - ~/.nvm/versions/node/v20.15.1/bin/npm
    pnpm: 9.6.0 - ~/Library/pnpm/pnpm
    bun: 1.0.25 - ~/.bun/bin/bun
  Browsers:
    Edge: 130.0.2849.46
    Safari: 18.0
  npmPackages:
    svelte: 5.0.0-next.260 => 5.0.0-next.260

Severity

annoyance

@huntabyte
Copy link
Owner Author

FIxed in latest @next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant