Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog is capturing focus events and stopping them from being propogated #755

Open
brsc2909 opened this issue Oct 11, 2024 · 0 comments
Open
Labels
Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5.

Comments

@brsc2909
Copy link

Describe the bug

not sure if this is a bug but it's making it impossible to use dialogs with fabricjs. when i try to edit a textbox object they key events are not getting passed to the canvas.

In the reproduction i've linked below. you should be able to open the dialog and click on the piece of text to edit it. instead the focus is being hijacked.

i've identified this listener as the culprit.

focusIn listener. which comes from melt-ui
image

is there any way to work around this?

thanks in advanced

Reproduction

https://stackblitz.com/edit/github-shpwk7-gzthpa?file=src%2Froutes%2F%2Bpage.svelte

Logs

n/a

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @sveltejs/kit: ^2.0.0 => 2.6.3 
    bits-ui: 0.21.16 => 0.21.16 
    svelte: ^4.2.8 => 4.2.19

Severity

blocking an upgrade

@huntabyte huntabyte added the Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5. label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5.
Projects
None yet
Development

No branches or pull requests

2 participants