Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mousedown / mouseup events to relevant bits. #546

Closed
caschbre opened this issue May 16, 2024 · 2 comments · May be fixed by #469
Closed

Add mousedown / mouseup events to relevant bits. #546

caschbre opened this issue May 16, 2024 · 2 comments · May be fixed by #469
Labels
enhancement An improvement to an existing feature/component Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5.

Comments

@caschbre
Copy link

Describe the feature in detail (code, mocks, or screenshots encouraged)

The current bits button is only exposing the following events...

on:click
on:change
on:keydown
on:keyup
on:mouseenter
on:mouseleave

Would it be possible to also add

on:mousedown
on:mouseup

What type of pull request would this be?

None

Provide relevant links or additional information.

No response

@huntabyte
Copy link
Owner

Works for me! Can't wait until Svelte 5 so that we don't have to manually expose all of these listeners 😃

@huntabyte huntabyte mentioned this issue Jun 9, 2024
4 tasks
@huntabyte huntabyte added enhancement An improvement to an existing feature/component Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5. labels Jul 9, 2024
@huntabyte huntabyte mentioned this issue Jul 31, 2024
70 tasks
@huntabyte
Copy link
Owner

Closing as fixed in bits-ui@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature/component Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants