Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog closes when highlighting text and mouse ends outside of dialog #337

Closed
ConProgramming opened this issue Feb 16, 2024 · 2 comments · May be fixed by #469
Closed

Dialog closes when highlighting text and mouse ends outside of dialog #337

ConProgramming opened this issue Feb 16, 2024 · 2 comments · May be fixed by #469
Labels
bug Something isn't working Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5.

Comments

@ConProgramming
Copy link

Describe the bug

Reproducible with main dialog example https://www.bits-ui.com/docs/components/dialog.

Highlighting text and ending with mouse inside dialog works fine. If you're highlighting and your mouse ends outside the dialog, the dialog inadvertently closes. This is not expected behavior.

Reproduction

https://www.bits-ui.com/docs/components/dialog

Logs

No response

System Info

Any system

Severity

annoyance
@huntabyte
Copy link
Owner

Will be closed once this is merged and bits is updated to that version of melt! Thank you! melt-ui/melt-ui#994

@huntabyte huntabyte added the bug Something isn't working label Feb 17, 2024
@huntabyte huntabyte mentioned this issue Mar 1, 2024
Merged
@huntabyte huntabyte mentioned this issue Jun 9, 2024
Open
4 tasks
@huntabyte huntabyte mentioned this issue Jul 31, 2024
Closed
70 tasks
@huntabyte huntabyte added the Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5. label Oct 3, 2024
@huntabyte
Copy link
Owner

Closing as fixed in bits-ui@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Svelte 5 Roadmap This issue is planned to be addressed or fixed when the library migrates to Svelte 5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

next: Svelte 5 huntabyte/bits-ui
2 participants
@ConProgramming @huntabyte