Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pointerenter event to Menubar.CheckboxItem #254

Closed
Juliiiian opened this issue Jan 4, 2024 · 2 comments · May be fixed by #469
Closed

add pointerenter event to Menubar.CheckboxItem #254

Juliiiian opened this issue Jan 4, 2024 · 2 comments · May be fixed by #469
Labels
help wanted Open to contributions

Comments

@Juliiiian
Copy link

Juliiiian commented Jan 4, 2024

Problem:

On Menubar.CheckboxItem there are the events pointermove and pointerleave to detect hovering over the element. But when using the pointermove event it is fired on every move, which can be sometimes performance heavy and unnecessary, since it would just work with the pointerenter event.

Solution:

I don't know if it should be added to every component. For example, you can hover over an item in the menu to just show what it will change and then actually change it when clicked, like a preview (that's my use case).

@huntabyte
Copy link
Owner

If we add this to one of the menu item components we should add it to all of them. The only thing we'll need to do is forward the events from the elements and update the types to include the proper event for each of them.

@huntabyte huntabyte added the help wanted Open to contributions label Jan 5, 2024
@huntabyte huntabyte mentioned this issue Jun 9, 2024
4 tasks
@huntabyte
Copy link
Owner

Closed by #403

@huntabyte huntabyte mentioned this issue Jul 31, 2024
70 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open to contributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants