Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading renamed files #203

Closed
Semir1212 opened this issue Jan 29, 2024 · 1 comment
Closed

Downloading renamed files #203

Semir1212 opened this issue Jan 29, 2024 · 1 comment
Assignees
Labels

Comments

@Semir1212
Copy link
Contributor

HH 1.15.3
Files 0.16.3

  • Upload file
  • Rename
  • Download

--> Downloaded file has initial name

@yurabakhtin
Copy link
Contributor

@luke- The problem was in browser caching, i.e. if url is not changed after previous downloading then browser downloads the file with same name from cache.
We already fixed similar issue after update a file content with adding url param hash_sha1 with value like 6d2c467f, but this param is not updated when file name is changed. This fix is from core side.
So I have decided to add a new param hash_name which 4 first chars of sha1(File->file_name), e.g. hash_name=ac1e and have done this only for this module because I think file name can be changed only by this module.
PR #204.

@luke- luke- closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants