From 6b86cf8828d73af9dad6f3c8bfe9f3dc7c269fe9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Th=C3=A9o=20FIDRY?= <theo.fidry@gmail.com>
Date: Wed, 21 Feb 2018 00:22:08 +0000
Subject: [PATCH] Optimize native function and constant calls

---
 README.md                                     | 36 +++++++++++
 composer.lock                                 | 10 ++--
 scoper.inc.php                                | 13 +---
 specs/class-FQ.php                            | 20 +++----
 ...-level-with-single-level-use-and-alias.php |  2 +-
 ...-scope-two-level-with-single-level-use.php |  4 +-
 specs/class-const/global-scope-two-level.php  |  4 +-
 ...-level-with-single-level-use-and-alias.php |  2 +-
 ...-scope-two-level-with-single-level-use.php |  4 +-
 .../class-const/namespace-scope-two-level.php |  4 +-
 specs/class/abstract.php                      |  6 +-
 specs/class/conditional.php                   | 10 ++--
 specs/class/final.php                         |  2 +-
 specs/class/interface.php                     |  2 +-
 specs/class/regular-extend.php                |  2 +-
 specs/class/regular.php                       |  6 +-
 specs/const/native-const.php                  | 59 +++++++++++++++++++
 specs/func-declaration/global.php             |  6 +-
 specs/func-declaration/method.php             |  4 +-
 specs/func-declaration/namespace.php          |  6 +-
 specs/function/native-func.php                | 59 +++++++++++++++++++
 ...-parts-with-single-level-use-and-alias.php |  4 +-
 ...-scope-two-parts-with-single-level-use.php |  8 +--
 specs/new/global-scope-two-parts.php          |  4 +-
 ...namespace-two-parts-with-two-level-use.php |  2 +-
 .../self-static-parent-method.php             |  4 +-
 ...-parts-with-single-level-use-and-alias.php |  6 +-
 ...-scope-two-parts-with-single-level-use.php |  8 +--
 .../static-method/global-scope-two-parts.php  |  4 +-
 ...namespace-two-parts-with-two-level-use.php |  2 +-
 specs/static-method/namespace-two-parts.php   |  2 +-
 specs/string-literal/func-arg.php             |  2 +-
 specs/string-literal/var.php                  |  2 +-
 specs/use/use-class.php                       |  2 +-
 src/NodeVisitor/NameStmtPrefixer.php          | 39 ++++++------
 35 files changed, 248 insertions(+), 102 deletions(-)
 create mode 100644 specs/const/native-const.php
 create mode 100644 specs/function/native-func.php

diff --git a/README.md b/README.md
index 821f1415..3485c169 100644
--- a/README.md
+++ b/README.md
@@ -45,6 +45,7 @@ potentially very difficult to debug due to dissimilar or unsupported package ver
 - [Limitations](#limitations)
     - [PSR-0 support](#psr-0-support)
     - [String values](#string-values)
+    - [Native functions and constants shadowing](#native-functions-shadowing)
 - [Contributing](#contributing)
 - [Credits](#credits)
 
@@ -437,6 +438,41 @@ bound to have confusing cases. For example:
   name or a random string.
 
 
+### Native functions and constants shadowing
+
+In the following example:
+
+```php
+<?php
+
+namespace Foo;
+
+is_array([]);
+
+```
+
+No use statement is used for the function `is_array`. This means that PHP will try to load the function `\Foo\is_array`
+and if fails to do so will fallback on `\is_array` (note that PHP does so only for functions and constants: not classes).
+
+In order to bring some performance optimisation, the call will nonetheless be prefixed in `\is_array`. This *will* break
+your code if you were relying on `\Foo\is_array` instead. This however should be _extremely_ rare, so if that happens
+you have two solutions: use a [patcher](#patchers) or simpler remove any ambiguity by making use of a use statement
+(which is unneeded outside of the context of prefixing your code):
+
+```php
+<?php
+
+namespace Foo;
+
+use function Foo\is_array;
+
+is_array([]);
+
+```
+
+The situation is exactly the same for constants.
+
+
 ## Contributing
 
 [Contribution Guide](CONTRIBUTING.md)
diff --git a/composer.lock b/composer.lock
index a1fc4f51..e7b9ca38 100644
--- a/composer.lock
+++ b/composer.lock
@@ -8,16 +8,16 @@
     "packages": [
         {
             "name": "nikic/php-parser",
-            "version": "v3.1.1",
+            "version": "v3.1.4",
             "source": {
                 "type": "git",
                 "url": "https://github.com/nikic/PHP-Parser.git",
-                "reference": "a1e8e1a30e1352f118feff1a8481066ddc2f234a"
+                "reference": "e57b3a09784f846411aa7ed664eedb73e3399078"
             },
             "dist": {
                 "type": "zip",
-                "url": "https://api.github.com/repos/nikic/PHP-Parser/zipball/a1e8e1a30e1352f118feff1a8481066ddc2f234a",
-                "reference": "a1e8e1a30e1352f118feff1a8481066ddc2f234a",
+                "url": "https://api.github.com/repos/nikic/PHP-Parser/zipball/e57b3a09784f846411aa7ed664eedb73e3399078",
+                "reference": "e57b3a09784f846411aa7ed664eedb73e3399078",
                 "shasum": ""
             },
             "require": {
@@ -55,7 +55,7 @@
                 "parser",
                 "php"
             ],
-            "time": "2017-09-02T17:10:46+00:00"
+            "time": "2018-01-25T21:31:33+00:00"
         },
         {
             "name": "ocramius/package-versions",
diff --git a/scoper.inc.php b/scoper.inc.php
index 9c99e443..983d7dff 100644
--- a/scoper.inc.php
+++ b/scoper.inc.php
@@ -44,21 +44,12 @@ function (string $filePath, string $prefix, string $contents): string {
             //
             // PHP-Parser patch
             //
-
-            if ($filePath === __DIR__.'/vendor/nikic/php-parser/lib/PhpParser/Lexer.php') {
-                return preg_replace(
-                    '%if \(defined\(\$name = \'PhpParser\\\\\\\\Parser\\\\\\\\Tokens%',
-                    'if (defined($name = \''.$prefix.'\\\\\\\\PhpParser\\\\\\\\Parser\\\\\\\\Tokens',
-                    $contents
-                );
-            }
-
             if ($filePath === realpath(__DIR__.'/vendor/nikic/php-parser/lib/PhpParser/NodeAbstract.php')) {
                 $length = 15 + strlen($prefix) + 1;
 
                 return preg_replace(
-                    '%rtrim\(get_class\(\$this\), \'_\'\), 15\)%',
-                    sprintf('rtrim(get_class($this), \'_\'), %d)', $length),
+                    '%strpos\((.+?)\) \+ 15%',
+                    sprintf('strpos($1) + %d', $length),
                     $contents
                 );
             }
diff --git a/specs/class-FQ.php b/specs/class-FQ.php
index b8affa38..b65c08f5 100644
--- a/specs/class-FQ.php
+++ b/specs/class-FQ.php
@@ -78,13 +78,13 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug\Foo\Bar;
 
 class Poz
 {
 }
-class_alias('Humbug\\Foo\\Bar\\Poz', 'Foo\\Bar\\Poz', \false);
+\class_alias('Humbug\\Foo\\Bar\\Poz', 'Foo\\Bar\\Poz', \false);
 namespace Humbug;
 
 use Humbug\Foo as X;
@@ -279,47 +279,47 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug\Foo\Bar;
 
 class Poz
 {
 }
-class_alias('Humbug\\Foo\\Bar\\Poz', 'Foo\\Bar\\Poz', \false);
+\class_alias('Humbug\\Foo\\Bar\\Poz', 'Foo\\Bar\\Poz', \false);
 namespace Humbug\A;
 
 class Aoo
 {
 }
-class_alias('Humbug\\A\\Aoo', 'A\\Aoo', \false);
+\class_alias('Humbug\\A\\Aoo', 'A\\Aoo', \false);
 class Foo
 {
 }
-class_alias('Humbug\\A\\Foo', 'A\\Foo', \false);
+\class_alias('Humbug\\A\\Foo', 'A\\Foo', \false);
 namespace Humbug\A\Foo;
 
 class Bar
 {
 }
-class_alias('Humbug\\A\\Foo\\Bar', 'A\\Foo\\Bar', \false);
+\class_alias('Humbug\\A\\Foo\\Bar', 'A\\Foo\\Bar', \false);
 namespace Humbug\A\Foo\Bar;
 
 class Poz
 {
 }
-class_alias('Humbug\\A\\Foo\\Bar\\Poz', 'A\\Foo\\Bar\\Poz', \false);
+\class_alias('Humbug\\A\\Foo\\Bar\\Poz', 'A\\Foo\\Bar\\Poz', \false);
 namespace Humbug\A\Aoo;
 
 class Aoz
 {
 }
-class_alias('Humbug\\A\\Aoo\\Aoz', 'A\\Aoo\\Aoz', \false);
+\class_alias('Humbug\\A\\Aoo\\Aoz', 'A\\Aoo\\Aoz', \false);
 namespace Humbug\A\Aoo\Aoz;
 
 class Poz
 {
 }
-class_alias('Humbug\\A\\Aoo\\Aoz\\Poz', 'A\\Aoo\\Aoz\\Poz', \false);
+\class_alias('Humbug\\A\\Aoo\\Aoz\\Poz', 'A\\Aoo\\Aoz\\Poz', \false);
 namespace Humbug\A;
 
 use Humbug\Foo as X;
diff --git a/specs/class-const/global-scope-two-level-with-single-level-use-and-alias.php b/specs/class-const/global-scope-two-level-with-single-level-use-and-alias.php
index 905afad6..c2665902 100644
--- a/specs/class-const/global-scope-two-level-with-single-level-use-and-alias.php
+++ b/specs/class-const/global-scope-two-level-with-single-level-use-and-alias.php
@@ -179,7 +179,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo as X;
diff --git a/specs/class-const/global-scope-two-level-with-single-level-use.php b/specs/class-const/global-scope-two-level-with-single-level-use.php
index a1d88d75..c6960a02 100644
--- a/specs/class-const/global-scope-two-level-with-single-level-use.php
+++ b/specs/class-const/global-scope-two-level-with-single-level-use.php
@@ -189,7 +189,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo;
@@ -235,7 +235,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo;
diff --git a/specs/class-const/global-scope-two-level.php b/specs/class-const/global-scope-two-level.php
index 147221db..91c8773a 100644
--- a/specs/class-const/global-scope-two-level.php
+++ b/specs/class-const/global-scope-two-level.php
@@ -110,7 +110,7 @@ class Command {}
 class Command
 {
 }
-class_alias('Humbug\\PHPUnit\\Command', 'PHPUnit\\Command', \false);
+\class_alias('Humbug\\PHPUnit\\Command', 'PHPUnit\\Command', \false);
 namespace Humbug;
 
 \Humbug\PHPUnit\Command::MAIN_CONST;
@@ -144,7 +144,7 @@ class Command {}
 class Command
 {
 }
-class_alias('Humbug\\PHPUnit\\Command', 'PHPUnit\\Command', \false);
+\class_alias('Humbug\\PHPUnit\\Command', 'PHPUnit\\Command', \false);
 namespace Humbug;
 
 \Humbug\PHPUnit\Command::MAIN_CONST;
diff --git a/specs/class-const/namespace-scope-two-level-with-single-level-use-and-alias.php b/specs/class-const/namespace-scope-two-level-with-single-level-use-and-alias.php
index c5fb0dfd..0790423d 100644
--- a/specs/class-const/namespace-scope-two-level-with-single-level-use-and-alias.php
+++ b/specs/class-const/namespace-scope-two-level-with-single-level-use-and-alias.php
@@ -183,7 +183,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug\A;
 
 use Humbug\Foo as X;
diff --git a/specs/class-const/namespace-scope-two-level-with-single-level-use.php b/specs/class-const/namespace-scope-two-level-with-single-level-use.php
index de532cc6..40249cc2 100644
--- a/specs/class-const/namespace-scope-two-level-with-single-level-use.php
+++ b/specs/class-const/namespace-scope-two-level-with-single-level-use.php
@@ -193,7 +193,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug\X;
 
 use Humbug\Foo;
@@ -240,7 +240,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug\X;
 
 use Humbug\Foo;
diff --git a/specs/class-const/namespace-scope-two-level.php b/specs/class-const/namespace-scope-two-level.php
index fd59c4ef..d3057562 100644
--- a/specs/class-const/namespace-scope-two-level.php
+++ b/specs/class-const/namespace-scope-two-level.php
@@ -113,7 +113,7 @@ class Command {}
 class Command
 {
 }
-class_alias('Humbug\\X\\PHPUnit\\Command', 'X\\PHPUnit\\Command', \false);
+\class_alias('Humbug\\X\\PHPUnit\\Command', 'X\\PHPUnit\\Command', \false);
 namespace Humbug\X;
 
 \Humbug\X\PHPUnit\Command::MAIN_CONST;
@@ -148,7 +148,7 @@ class Command {}
 class Command
 {
 }
-class_alias('Humbug\\PHPUnit\\Command', 'PHPUnit\\Command', \false);
+\class_alias('Humbug\\PHPUnit\\Command', 'PHPUnit\\Command', \false);
 namespace Humbug\X;
 
 \Humbug\PHPUnit\Command::MAIN_CONST;
diff --git a/specs/class/abstract.php b/specs/class/abstract.php
index 287c050a..beeab07f 100644
--- a/specs/class/abstract.php
+++ b/specs/class/abstract.php
@@ -91,7 +91,7 @@ public function a()
     }
     public abstract function b();
 }
-class_alias('Humbug\\Foo\\A', 'Foo\\A', \false);
+\class_alias('Humbug\\Foo\\A', 'Foo\\A', \false);
 
 PHP
         ],
@@ -154,7 +154,7 @@ public function a()
     {
     }
 }
-class_alias('Humbug\\Foo\\WA', 'Foo\\WA', \false);
+\class_alias('Humbug\\Foo\\WA', 'Foo\\WA', \false);
 namespace Humbug\Bar;
 
 abstract class B
@@ -169,7 +169,7 @@ public function b()
     {
     }
 }
-class_alias('Humbug\\Bar\\WB', 'Bar\\WB', \false);
+\class_alias('Humbug\\Bar\\WB', 'Bar\\WB', \false);
 namespace Humbug;
 
 abstract class C
diff --git a/specs/class/conditional.php b/specs/class/conditional.php
index 2d187c25..28153b77 100644
--- a/specs/class/conditional.php
+++ b/specs/class/conditional.php
@@ -83,7 +83,7 @@ class A {}
 
 namespace Humbug\Foo;
 
-if (true) {
+if (\true) {
     class A
     {
     }
@@ -107,7 +107,7 @@ class A {}
 
 namespace Humbug\Foo;
 
-if (true) {
+if (\true) {
     class A
     {
     }
@@ -141,21 +141,21 @@ class C {}
 
 namespace Humbug\X;
 
-if (true) {
+if (\true) {
     class A
     {
     }
 }
 namespace Humbug\Y;
 
-if (true) {
+if (\true) {
     class B
     {
     }
 }
 namespace Humbug\Z;
 
-if (true) {
+if (\true) {
     class C
     {
     }
diff --git a/specs/class/final.php b/specs/class/final.php
index 01a0e17a..ab9c6a05 100644
--- a/specs/class/final.php
+++ b/specs/class/final.php
@@ -70,7 +70,7 @@ final class A {}
 final class A
 {
 }
-class_alias('Humbug\\Foo\\A', 'Foo\\A', \false);
+\class_alias('Humbug\\Foo\\A', 'Foo\\A', \false);
 
 PHP
         ],
diff --git a/specs/class/interface.php b/specs/class/interface.php
index 74cf9f5c..75d511dc 100644
--- a/specs/class/interface.php
+++ b/specs/class/interface.php
@@ -114,7 +114,7 @@ interface A extends \Humbug\Foo\C, \Humbug\Foo\D, \Iterator
 {
     public function a();
 }
-class_alias('Humbug\\Foo\\A', 'Foo\\A', \false);
+\class_alias('Humbug\\Foo\\A', 'Foo\\A', \false);
 
 PHP
         ],
diff --git a/specs/class/regular-extend.php b/specs/class/regular-extend.php
index a56593a0..c5fb3333 100644
--- a/specs/class/regular-extend.php
+++ b/specs/class/regular-extend.php
@@ -106,7 +106,7 @@ public function a()
 class B extends \Humbug\Foo\A
 {
 }
-class_alias('Humbug\\Foo\\B', 'Foo\\B', \false);
+\class_alias('Humbug\\Foo\\B', 'Foo\\B', \false);
 
 PHP
         ],
diff --git a/specs/class/regular.php b/specs/class/regular.php
index 21d5e939..cc3e4528 100644
--- a/specs/class/regular.php
+++ b/specs/class/regular.php
@@ -85,7 +85,7 @@ public function a()
     {
     }
 }
-class_alias('Humbug\\Foo\\A', 'Foo\\A', \false);
+\class_alias('Humbug\\Foo\\A', 'Foo\\A', \false);
 
 PHP
         ],
@@ -207,7 +207,7 @@ public function a()
     {
     }
 }
-class_alias('Humbug\\Foo\\A', 'Foo\\A', \false);
+\class_alias('Humbug\\Foo\\A', 'Foo\\A', \false);
 class B
 {
     public function b()
@@ -234,7 +234,7 @@ public function b()
     {
     }
 }
-class_alias('Humbug\\Bar\\B', 'Bar\\B', \false);
+\class_alias('Humbug\\Bar\\B', 'Bar\\B', \false);
 class C
 {
     public function c()
diff --git a/specs/const/native-const.php b/specs/const/native-const.php
new file mode 100644
index 00000000..79af330e
--- /dev/null
+++ b/specs/const/native-const.php
@@ -0,0 +1,59 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the humbug/php-scoper package.
+ *
+ * Copyright (c) 2017 Théo FIDRY <theo.fidry@gmail.com>,
+ *                    Pádraic Brady <padraic.brady@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+return [
+    'meta' => [
+        'title' => 'Native constant calls',
+        // Default values. If not specified will be the one used
+        'prefix' => 'Humbug',
+        'whitelist' => [],
+    ],
+
+    'Internal function in a namespace: make the call into a FQ call' => <<<'PHP'
+<?php
+
+namespace Acme;
+
+$x = DIRECTORY_SEPARATOR;
+
+----
+<?php
+
+namespace Humbug\Acme;
+
+$x = \DIRECTORY_SEPARATOR;
+
+PHP
+    ,
+
+    'Namespaced function having the same name as an internal function: prefix & make the call into a FQ call' => <<<'PHP'
+<?php
+
+namespace Acme;
+
+use const Acme\DIRECTORY_SEPARATOR;
+
+$x = DIRECTORY_SEPARATOR;
+
+----
+<?php
+
+namespace Humbug\Acme;
+
+use const Humbug\Acme\DIRECTORY_SEPARATOR;
+$x = \Humbug\Acme\DIRECTORY_SEPARATOR;
+
+PHP
+    ,
+];
diff --git a/specs/func-declaration/global.php b/specs/func-declaration/global.php
index b196ca87..df82e0fb 100644
--- a/specs/func-declaration/global.php
+++ b/specs/func-declaration/global.php
@@ -73,7 +73,7 @@ class Bar
 class Y
 {
 }
-class_alias('Humbug\\X\\Y', 'X\\Y', \false);
+\class_alias('Humbug\\X\\Y', 'X\\Y', \false);
 namespace Humbug;
 
 function foo(\Humbug\Foo $arg0, \Humbug\Foo $arg1, \Humbug\Foo\Bar $arg2, \Humbug\Foo\Bar $arg3, \ArrayIterator $arg4, \ArrayIterator $arg5, \Humbug\X\Y $arg6, \Humbug\X\Y $arg7)
@@ -163,7 +163,7 @@ class Bar
 class Y
 {
 }
-class_alias('Humbug\\X\\Y', 'X\\Y', \false);
+\class_alias('Humbug\\X\\Y', 'X\\Y', \false);
 namespace Humbug;
 
 use Humbug\Foo;
@@ -259,7 +259,7 @@ class Bar
 class Y
 {
 }
-class_alias('Humbug\\X\\Y', 'X\\Y', \false);
+\class_alias('Humbug\\X\\Y', 'X\\Y', \false);
 namespace Humbug;
 
 use Humbug\Foo;
diff --git a/specs/func-declaration/method.php b/specs/func-declaration/method.php
index 91663baf..a5aba80c 100644
--- a/specs/func-declaration/method.php
+++ b/specs/func-declaration/method.php
@@ -86,7 +86,7 @@ class Bar
 class Y
 {
 }
-class_alias('Humbug\\X\\Y', 'X\\Y', \false);
+\class_alias('Humbug\\X\\Y', 'X\\Y', \false);
 namespace Humbug;
 
 class Main
@@ -189,7 +189,7 @@ class Bar
 class Y
 {
 }
-class_alias('Humbug\\X\\Y', 'X\\Y', \false);
+\class_alias('Humbug\\X\\Y', 'X\\Y', \false);
 namespace Humbug;
 
 use Humbug\Foo;
diff --git a/specs/func-declaration/namespace.php b/specs/func-declaration/namespace.php
index cd4be748..dc896e18 100644
--- a/specs/func-declaration/namespace.php
+++ b/specs/func-declaration/namespace.php
@@ -84,7 +84,7 @@ class Bar
 class Y
 {
 }
-class_alias('Humbug\\X\\Y', 'X\\Y', \false);
+\class_alias('Humbug\\X\\Y', 'X\\Y', \false);
 namespace Humbug\Pi\Foo;
 
 class Bar
@@ -175,7 +175,7 @@ class Bar
 class Y
 {
 }
-class_alias('Humbug\\X\\Y', 'X\\Y', \false);
+\class_alias('Humbug\\X\\Y', 'X\\Y', \false);
 namespace Humbug\Pi\X;
 
 class Y
@@ -278,7 +278,7 @@ class Bar
 class Y
 {
 }
-class_alias('Humbug\\X\\Y', 'X\\Y', \false);
+\class_alias('Humbug\\X\\Y', 'X\\Y', \false);
 namespace Humbug\Pi;
 
 use Humbug\Foo;
diff --git a/specs/function/native-func.php b/specs/function/native-func.php
new file mode 100644
index 00000000..9a6a4c57
--- /dev/null
+++ b/specs/function/native-func.php
@@ -0,0 +1,59 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the humbug/php-scoper package.
+ *
+ * Copyright (c) 2017 Théo FIDRY <theo.fidry@gmail.com>,
+ *                    Pádraic Brady <padraic.brady@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+return [
+    'meta' => [
+        'title' => 'Native function calls',
+        // Default values. If not specified will be the one used
+        'prefix' => 'Humbug',
+        'whitelist' => [],
+    ],
+
+    'Internal function in a namespace: make the call into a FQ call' => <<<'PHP'
+<?php
+
+namespace Acme;
+
+$x = is_array([]);
+
+----
+<?php
+
+namespace Humbug\Acme;
+
+$x = \is_array([]);
+
+PHP
+    ,
+
+    'Namespaced function having the same name as an internal function: prefix & make the call into a FQ call' => <<<'PHP'
+<?php
+
+namespace Acme;
+
+use function Acme\is_array;
+
+$x = is_array([]);
+
+----
+<?php
+
+namespace Humbug\Acme;
+
+use function Humbug\Acme\is_array;
+$x = \Humbug\Acme\is_array([]);
+
+PHP
+    ,
+];
diff --git a/specs/new/global-scope-two-parts-with-single-level-use-and-alias.php b/specs/new/global-scope-two-parts-with-single-level-use-and-alias.php
index e7684372..12c08b40 100644
--- a/specs/new/global-scope-two-parts-with-single-level-use-and-alias.php
+++ b/specs/new/global-scope-two-parts-with-single-level-use-and-alias.php
@@ -234,7 +234,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo as A;
@@ -272,7 +272,7 @@ class Bar {}
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo\Bar as A;
diff --git a/specs/new/global-scope-two-parts-with-single-level-use.php b/specs/new/global-scope-two-parts-with-single-level-use.php
index 00c1aeea..b6cd9536 100644
--- a/specs/new/global-scope-two-parts-with-single-level-use.php
+++ b/specs/new/global-scope-two-parts-with-single-level-use.php
@@ -101,7 +101,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo;
@@ -191,7 +191,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo;
@@ -283,7 +283,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo\Bar;
@@ -383,7 +383,7 @@ class Bar
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo\Bar;
diff --git a/specs/new/global-scope-two-parts.php b/specs/new/global-scope-two-parts.php
index f715228e..e18330cf 100644
--- a/specs/new/global-scope-two-parts.php
+++ b/specs/new/global-scope-two-parts.php
@@ -113,7 +113,7 @@ class Bar {}
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 new \Humbug\Foo\Bar();
@@ -149,7 +149,7 @@ class Bar {}
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 new \Humbug\Foo\Bar();
diff --git a/specs/new/namespace-two-parts-with-two-level-use.php b/specs/new/namespace-two-parts-with-two-level-use.php
index ba3a1989..5f955b2d 100644
--- a/specs/new/namespace-two-parts-with-two-level-use.php
+++ b/specs/new/namespace-two-parts-with-two-level-use.php
@@ -151,7 +151,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\X\\Foo\\Bar', 'X\\Foo\\Bar', \false);
+\class_alias('Humbug\\X\\Foo\\Bar', 'X\\Foo\\Bar', \false);
 namespace Humbug\A;
 
 use Humbug\X\Foo;
diff --git a/specs/special-keywords/self-static-parent-method.php b/specs/special-keywords/self-static-parent-method.php
index ee53493f..1b365e92 100644
--- a/specs/special-keywords/self-static-parent-method.php
+++ b/specs/special-keywords/self-static-parent-method.php
@@ -197,7 +197,7 @@ public function __construct(string $name)
     }
     public static function who()
     {
-        echo __METHOD__ . PHP_EOL;
+        echo __METHOD__ . \PHP_EOL;
     }
     public static function test()
     {
@@ -227,7 +227,7 @@ public function __construct(string $name)
     }
     public static function who()
     {
-        echo __METHOD__ . PHP_EOL;
+        echo __METHOD__ . \PHP_EOL;
     }
 }
 namespace Humbug;
diff --git a/specs/static-method/global-scope-two-parts-with-single-level-use-and-alias.php b/specs/static-method/global-scope-two-parts-with-single-level-use-and-alias.php
index cf367180..7de80f12 100644
--- a/specs/static-method/global-scope-two-parts-with-single-level-use-and-alias.php
+++ b/specs/static-method/global-scope-two-parts-with-single-level-use-and-alias.php
@@ -223,7 +223,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo as A;
@@ -261,7 +261,7 @@ class Bar {}
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo\Bar as A;
@@ -353,7 +353,7 @@ class A
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo\Bar as A;
diff --git a/specs/static-method/global-scope-two-parts-with-single-level-use.php b/specs/static-method/global-scope-two-parts-with-single-level-use.php
index fb1ef48c..5e9b8013 100644
--- a/specs/static-method/global-scope-two-parts-with-single-level-use.php
+++ b/specs/static-method/global-scope-two-parts-with-single-level-use.php
@@ -223,7 +223,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo;
@@ -261,7 +261,7 @@ class Bar {}
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo\Bar;
@@ -307,7 +307,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo;
@@ -347,7 +347,7 @@ class Bar {}
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 class Bar
diff --git a/specs/static-method/global-scope-two-parts.php b/specs/static-method/global-scope-two-parts.php
index d52f098a..964f0a0f 100644
--- a/specs/static-method/global-scope-two-parts.php
+++ b/specs/static-method/global-scope-two-parts.php
@@ -104,7 +104,7 @@ class Bar {}
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 \Humbug\Foo\Bar::main();
@@ -137,7 +137,7 @@ class Bar {}
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 \Humbug\Foo\Bar::main();
diff --git a/specs/static-method/namespace-two-parts-with-two-level-use.php b/specs/static-method/namespace-two-parts-with-two-level-use.php
index c7aba103..185ace01 100644
--- a/specs/static-method/namespace-two-parts-with-two-level-use.php
+++ b/specs/static-method/namespace-two-parts-with-two-level-use.php
@@ -151,7 +151,7 @@ class Foo
 class Bar
 {
 }
-class_alias('Humbug\\X\\Foo\\Bar', 'X\\Foo\\Bar', \false);
+\class_alias('Humbug\\X\\Foo\\Bar', 'X\\Foo\\Bar', \false);
 namespace Humbug\A;
 
 use Humbug\X\Foo;
diff --git a/specs/static-method/namespace-two-parts.php b/specs/static-method/namespace-two-parts.php
index c0dc073f..fbc6cde2 100644
--- a/specs/static-method/namespace-two-parts.php
+++ b/specs/static-method/namespace-two-parts.php
@@ -113,7 +113,7 @@ class Bar {}
 class Bar
 {
 }
-class_alias('Humbug\\X\\Foo\\Bar', 'X\\Foo\\Bar', \false);
+\class_alias('Humbug\\X\\Foo\\Bar', 'X\\Foo\\Bar', \false);
 namespace Humbug\X;
 
 \Humbug\X\Foo\Bar::main();
diff --git a/specs/string-literal/func-arg.php b/specs/string-literal/func-arg.php
index 13fdfd24..af1d4d71 100644
--- a/specs/string-literal/func-arg.php
+++ b/specs/string-literal/func-arg.php
@@ -135,7 +135,7 @@ class Yaml {}
 class Yaml
 {
 }
-class_alias('Humbug\\Symfony\\Component\\Yaml\\Yaml', 'Symfony\\Component\\Yaml\\Yaml', \false);
+\class_alias('Humbug\\Symfony\\Component\\Yaml\\Yaml', 'Symfony\\Component\\Yaml\\Yaml', \false);
 namespace Humbug;
 
 \Humbug\foo(\Humbug\Symfony\Component\Yaml\Yaml::class);
diff --git a/specs/string-literal/var.php b/specs/string-literal/var.php
index da970c22..7191a175 100644
--- a/specs/string-literal/var.php
+++ b/specs/string-literal/var.php
@@ -152,7 +152,7 @@ class Yaml {}
 class Yaml
 {
 }
-class_alias('Humbug\\Symfony\\Component\\Yaml\\Yaml', 'Symfony\\Component\\Yaml\\Yaml', \false);
+\class_alias('Humbug\\Symfony\\Component\\Yaml\\Yaml', 'Symfony\\Component\\Yaml\\Yaml', \false);
 namespace Humbug;
 
 $x = \Humbug\Symfony\Component\Yaml\Yaml::class;
diff --git a/specs/use/use-class.php b/specs/use/use-class.php
index 36824512..6e3a9fac 100644
--- a/specs/use/use-class.php
+++ b/specs/use/use-class.php
@@ -234,7 +234,7 @@ class Bar {}
 class Bar
 {
 }
-class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
+\class_alias('Humbug\\Foo\\Bar', 'Foo\\Bar', \false);
 namespace Humbug;
 
 use Humbug\Foo\Bar;
diff --git a/src/NodeVisitor/NameStmtPrefixer.php b/src/NodeVisitor/NameStmtPrefixer.php
index bd075aa1..4c7c70a2 100644
--- a/src/NodeVisitor/NameStmtPrefixer.php
+++ b/src/NodeVisitor/NameStmtPrefixer.php
@@ -151,27 +151,28 @@ private function prefixName(Name $name): Node
             }
         }
 
-        if ($parentNode instanceof ConstFetch
-            && (
-                $this->reflector->isConstantInternal($resolvedName->toString())
-                // Constants have a fallback autoloading so we cannot prefix them when the name is ambiguous
-                // See https://wiki.php.net/rfc/fallback-to-root-scope-deprecation
-                || false === ($resolvedName instanceof FullyQualified)
-            )
-        ) {
-            return $resolvedName;
+        // Constants have a fallback autoloading so we cannot prefix them when the name is ambiguous
+        // See https://wiki.php.net/rfc/fallback-to-root-scope-deprecation
+        if ($parentNode instanceof ConstFetch) {
+            if ($this->reflector->isConstantInternal($resolvedName->toString())) {
+                return new FullyQualified($resolvedName->toString(), $resolvedName->getAttributes());
+            }
+
+            if (false === ($resolvedName instanceof FullyQualified)) {
+                return $resolvedName;
+            }
         }
 
-        if (
-            $parentNode instanceof FuncCall
-            && (
-                $this->reflector->isFunctionInternal($resolvedName->toString())
-                // Functions have a fallback autoloading so we cannot prefix them when the name is ambiguous
-                // See https://wiki.php.net/rfc/fallback-to-root-scope-deprecation
-                || false === ($resolvedName instanceof FullyQualified)
-            )
-        ) {
-            return $resolvedName;
+        // Functions have a fallback autoloading so we cannot prefix them when the name is ambiguous
+        // See https://wiki.php.net/rfc/fallback-to-root-scope-deprecation
+        if ($parentNode instanceof FuncCall) {
+            if ($this->reflector->isFunctionInternal($resolvedName->toString())) {
+                return new FullyQualified($resolvedName->toString(), $resolvedName->getAttributes());
+            }
+
+            if (false === ($resolvedName instanceof FullyQualified)) {
+                return $resolvedName;
+            }
         }
 
         if ('self' === (string) $resolvedName && $parentNode instanceof ClassMethod) {