Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classes that are not scoped (part of the public API) have @internal annotation added to them since 0.18.5 #924

Closed
sebastianbergmann opened this issue Dec 1, 2023 · 1 comment · Fixed by #928
Closed

Classes that are not scoped (part of the public API) have @internal annotation added to them since 0.18.5 #924

sebastianbergmann opened this issue Dec 1, 2023 · 1 comment · Fixed by #928

Comments

@sebastianbergmann
Copy link
Contributor

sebastianbergmann commented Dec 1, 2023 •
edited
Loading

Since #882, classes that are not scoped (because they should be part of the public API exposed by the PHAR) have an @internal annotation added to them.

See sebastianbergmann/phpunit#5596 for details.
@sebastianbergmann sebastianbergmann mentioned this issue Dec 1, 2023
Closed
@sebastianbergmann
Copy link
Contributor Author

@theofidry wrote in sebastianbergmann/phpunit#5596 (comment):

If it's a big deal I would just revert the whole thing, I am not sure yet it is working as intended.

I'm not sure if you should revert this or not. I just need to be able to disable this behaviour, I guess.

@theofidry theofidry mentioned this issue Dec 7, 2023
Merged
@sebastianbergmann sebastianbergmann changed the title Classes that are not scoped (part of the public API) have @internal annotation added to them sind 0.18.5 Classes that are not scoped (part of the public API) have @internal annotation added to them since 0.18.5 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "feat: Mark all declarations as internal (#882)" theofidry/php-scoper
1 participant
@sebastianbergmann