Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a warning for wrong type of clean area and add new dock #224

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Oct 19, 2024

No description provided.

@Lash-L Lash-L merged commit c334eb2 into main Oct 19, 2024
7 checks passed
@Lash-L Lash-L deleted the clean_area_fix branch October 19, 2024 19:56
@Lash-L
Copy link
Collaborator Author

Lash-L commented Oct 19, 2024

@humbertogontijo You need to add 2FA to your pypi account, it will not allow pushing to pypi otherwise

https://github.com/humbertogontijo/python-roborock/actions/runs/11420333457/job/31775927391#step:5:211

400 User 'humbertogontijo' does not have two-factor authentication enabled. Please enable two-factor authentication before attempting to upload to PyPI. See https://pypi.org/help/#two-factor-authentication for more information.

May also be a good idea to add me a secondary user to the pypi account (Lash-L on pypi) in case you ever lose your 2fa

@Lash-L
Copy link
Collaborator Author

Lash-L commented Oct 20, 2024

@humbertogontijo Let me know when you have a chance to do it and i will try to repush to pypi

@humbertogontijo
Copy link
Owner

I just added the 2FA and added you as owner in the pypi repository

@Lash-L
Copy link
Collaborator Author

Lash-L commented Oct 21, 2024

Any chance you could reset us back to commit c334eb2

Alternatively, I can make a new PR. But it wont rebuild as long as they 2.6.1 commit exists. I deleted the release and the tag, but I don't have permissions to do a force push or anything to remove the 2.6.1 commit

@humbertogontijo
Copy link
Owner

Done. You can create a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants