Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--light-bg: values to light #20

Open
pohly opened this issue Jul 19, 2018 · 6 comments
Open

--light-bg: values to light #20

pohly opened this issue Jul 19, 2018 · 6 comments

Comments

@pohly
Copy link

pohly commented Jul 19, 2018

Despite calling humanlog with --light-bg, additional values get colored with a very light color that is almost unreadable on a white background.

Apparently because of:

ValColor:          color.New(color.FgHiWhite),

Should different colors be used depending on --light-bg?

@aybabtme
Copy link
Collaborator

Hi @pohly, I recently changed the colors to use default ANSI colors so the tool would respect user themes. Doing this, I made the --light-bg become a no-op since in theory, a user's light color theme should be setup with appropriate colors. I setup colors like you link that I thought looked good enough on my terminal, but I'm sure others will have a different experience. If you have a chance, I'd appreciate if you could play with this color.FgHiWhite and let me know what looks best for you? Otherwise if you can share with me what your terminal color theme is, so I can test locally.

@pohly
Copy link
Author

pohly commented Jul 19, 2018

Thanks for the prompt response and the explanation. So I guess I really have to experiment with color.FgHiWhite and what might work better.

My desktop is a mixture: xmonad as window manager, Xfce as desktop, GNOME terminal as terminal app. The GNOME theme is Adwaita (shown in both Xfce and gnome-tweak-tool), with "Global dark theme" off (gnome-tweak-tool). A standard Xfce desktop should look the same.

@rickw
Copy link

rickw commented Jul 27, 2018

screen shot 2018-07-26 at 8 45 16 pm

text all the time and on a light background the fields are always white with or without --light-bg

screen shot 2018-07-26 at 8 48 33 pm

on macOS

using the previous version the white is grey and actually readable...and light-bg works in that version

Figured it out, basically. The ANSI update and a theme that seems to conflict, other themes produce readable results. (brew install --HEAD is better than the last release)

@ChiefMateStarbuck
Copy link

Having the same issue here. logs are unreadable in light mode.

@hampgoodwin
Copy link

hampgoodwin commented Aug 5, 2021

Bump <3

Edit:

Seems like the ANSI colors are just awful; so the theme is the issue which needs updating.

@aybabtme
Copy link
Collaborator

I hope to rework this soon so that it'll work better. Apologies for the current state of light-bg colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants