Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redis resource #4

Merged
merged 1 commit into from
Dec 22, 2023
Merged

feat: redis resource #4

merged 1 commit into from
Dec 22, 2023

Conversation

johanneswuerbach
Copy link
Contributor

@johanneswuerbach johanneswuerbach commented Dec 21, 2023

An AWS ElastiCache resource using a classic instance.

Serverless instances aren't available in TF yet hashicorp/terraform-provider-aws#34951, so this can't be added yet.

@johanneswuerbach johanneswuerbach force-pushed the redis-resource branch 2 times, most recently from d1ec66f to ff4c228 Compare December 21, 2023 14:29
@johanneswuerbach johanneswuerbach marked this pull request as ready for review December 21, 2023 14:29
@johanneswuerbach johanneswuerbach requested a review from a team as a code owner December 21, 2023 14:29
Copy link
Contributor

@mateuszjenek mateuszjenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Just one comment

@@ -0,0 +1,64 @@
variable "humanitec_organization" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, removed. Will check if we can somehow check this in CI.

@johanneswuerbach johanneswuerbach merged commit c15f115 into main Dec 22, 2023
1 check passed
@johanneswuerbach johanneswuerbach deleted the redis-resource branch December 22, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants