Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: imagepullsecret config #23

Merged
merged 1 commit into from
Jun 14, 2024
Merged

feat: imagepullsecret config #23

merged 1 commit into from
Jun 14, 2024

Conversation

johanneswuerbach
Copy link
Contributor

This add a config Resource Definition, which injects imagePullSecrets into deployed workloads. imagePullSecrets are required to pull private ECR images from a k8s cluster running outside AWS.

@johanneswuerbach johanneswuerbach requested a review from a team as a code owner June 11, 2024 20:05
astromechza
astromechza approved these changes Jun 13, 2024
View reviewed changes
Copy link

@astromechza astromechza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. can't see any obvious issues. Except maybe we could use the fail sprig function more than we do to ensure inputs are not empty.

@johanneswuerbach johanneswuerbach merged commit ef1386d into humanitec-architecture:main Jun 14, 2024
1 check passed
@johanneswuerbach johanneswuerbach deleted the imagepullsecret branch June 14, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astromechza astromechza astromechza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanneswuerbach @astromechza