Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align resource naming #16

Merged

Conversation

johanneswuerbach
Copy link
Contributor

Every resource gets an customisable name variable, that can be passed from the outside directly (or from a template).

If this isn't provided, we default to {prefix}-{app-id}-{env-id}-{res-id}, cleanup all unsupported chars and trim to the expected length.

I would also propose to name the example apps, hum-rp-example-{resource-type} to simplify finding them and "test" doesn't sound really encouraging.

The generated s3 resource name in this case is a bit long, but I don't really see a way around this (unless we drop the prefix from the resource name itself 🤔 )

image

If this looks good I'll update the remaining resources/examples.

@johanneswuerbach johanneswuerbach force-pushed the naming branch 3 times, most recently from 97be2ec to c462834 Compare February 13, 2024 16:27
@johanneswuerbach johanneswuerbach marked this pull request as ready for review February 13, 2024 16:27
@johanneswuerbach johanneswuerbach requested a review from a team as a code owner February 13, 2024 16:27
modules/rds/aurora/main.tf Outdated Show resolved Hide resolved
modules/s3/basic/main.tf Outdated Show resolved Hide resolved
@johanneswuerbach johanneswuerbach merged commit 0b41a3f into humanitec-architecture:main Feb 14, 2024
1 check passed
@johanneswuerbach johanneswuerbach deleted the naming branch February 14, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants