Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every resource gets an customisable
name
variable, that can be passed from the outside directly (or from a template).If this isn't provided, we default to
{prefix}-{app-id}-{env-id}-{res-id}
, cleanup all unsupported chars and trim to the expected length.I would also propose to name the example apps,
hum-rp-example-{resource-type}
to simplify finding them and "test" doesn't sound really encouraging.The generated s3 resource name in this case is a bit long, but I don't really see a way around this (unless we drop the prefix from the resource name itself 🤔 )
If this looks good I'll update the remaining resources/examples.