Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: s3 / sqs resources with workload identity #10

Merged
merged 5 commits into from
Feb 7, 2024
Merged

feat: s3 / sqs resources with workload identity #10

merged 5 commits into from
Feb 7, 2024

Conversation

johanneswuerbach
Copy link
Contributor

@johanneswuerbach johanneswuerbach commented Jan 10, 2024 •
edited
Loading

s3 & sqs resources with workload identity

@johanneswuerbach johanneswuerbach changed the title feat: s3 example feat: s3 / sqs resources with workload identity Feb 6, 2024
@johanneswuerbach johanneswuerbach marked this pull request as ready for review February 6, 2024 21:42
@johanneswuerbach johanneswuerbach requested a review from a team as a code owner February 6, 2024 21:42
mateuszjenek
mateuszjenek approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@mateuszjenek mateuszjenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanneswuerbach johanneswuerbach merged commit da70444 into humanitec-architecture:main Feb 7, 2024
1 check passed
@johanneswuerbach johanneswuerbach deleted the s3-example branch February 7, 2024 11:11
@johanneswuerbach johanneswuerbach mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszjenek mateuszjenek mateuszjenek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanneswuerbach @mateuszjenek