suspend PriorityQueue when no message is available(fix #14) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now PriorityQueue::deque() becomes async and always return MessageContainer and never return nil. When no message is available, sleep with withCheckedContinuation until new message is comming. With this change, HPRTMPExample CPU load becomes 14% for my iPhone 14 pro (previous: more than 100%).
Open
Fix of [2d5ebda] does not handle task cancellation. withCheckedContinuation block forever, which cause memory leak. withTaskCancellationHandler break properly even if withCheckedContinuation is waiting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now PriorityQueue::deque() becomes async and always return MessageContainer and never return nil. When no message is available, sleep with withCheckedContinuation until new message is comming.
With this change, HPRTMPExample CPU load becomes 14% for my iPhone 14 pro (previous: more than 100%).