Add explicit null checking for charset in SimpleHttpClient#encodeRequ…

…estParams (alibaba#1589)
hughpearse · Jul 7, 2020 · 46ac004 · 46ac004
1 parent 328a815
commit 46ac004
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/...p/src/main/java/com/alibaba/csp/sentinel/transport/heartbeat/client/SimpleHttpClient.java b/...p/src/main/java/com/alibaba/csp/sentinel/transport/heartbeat/client/SimpleHttpClient.java
@@ -156,6 +156,9 @@ private String getStatusLine(RequestMethod type, String requestPath) {
      * @return encoded request parameters, or empty string ("") if no parameters are provided
      */
     private String encodeRequestParams(Map<String, String> paramsMap, Charset charset) {
+        if (charset == null) {
+            throw new IllegalArgumentException("charset is not allowed to be null");
+        }
         if (paramsMap == null || paramsMap.isEmpty()) {
             return "";
         }