-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testing] rename skip targets + docs #7863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas00
changed the title
rename skip targets + docs
[testing] rename skip targets + docs
Oct 17, 2020
sshleifer
approved these changes
Oct 17, 2020
sgugger
approved these changes
Oct 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this! Just added some nits.
I resolved conflicts - it's good to go now. |
LysandreJik
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very welcome change! Thanks @stas00!
fabiocapsouza
pushed a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
* rename skip targets + docs * fix quotes * style * Apply suggestions from code review Co-authored-by: Sylvain Gugger <[email protected]> * small improvements * fix Co-authored-by: Sylvain Gugger <[email protected]>
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
This reverts commit 44f78bd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #6349 this PR brings consistency to skip decorators, so now we will have:
require_torch
- this test will run only under torchrequire_torch_gpu
- asrequire_torch
plus requires at least 1 GPUrequire_torch_multigpu
- asrequire_torch
plus requires at least 2 GPUsrequire_torch_non_multigpu
- asrequire_torch
plus requires 0 or 1 GPUsrequire_torch_tpu
- asrequire_torch
plus requires at least 1 TPUDocumentation updated and expanded.
The main change was done by running:
Fixes: #6349
@LysandreJik, @sgugger, @sshleifer