Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix llava next tie_word_embeddings config #30640

Merged
merged 3 commits into from
May 6, 2024
Merged

Fix llava next tie_word_embeddings config #30640

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f75c3fa
fix llava next embedding
SunMarc May 3, 2024
153cd10
add docstring
SunMarc May 3, 2024
b5e4a99
Update src/transformers/models/llava_next/configuration_llava_next.py
SunMarc May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/transformers/models/llava_next/configuration_llava_next.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ class LlavaNextConfig(PretrainedConfig):
image_grid_pinpoints (`List`, *optional*, defaults to `[[336, 672], [672, 336], [672, 672], [1008, 336], [336, 1008]]`):
A list of possible resolutions to use for processing high resolution images. Each item in the list should be a tuple or list
of the form `(height, width)`.
tie_word_embeddings (`bool`, *optional*, defaults to `False`):
Whether to tie weight embeddings
SunMarc marked this conversation as resolved.
Show resolved Hide resolved

Example:

Expand Down Expand Up @@ -90,6 +92,7 @@ def __init__(
vision_feature_select_strategy="default",
vision_feature_layer=-2,
image_grid_pinpoints=None,
tie_word_embeddings=False,
**kwargs,
):
self.ignore_index = ignore_index
Expand Down Expand Up @@ -138,4 +141,4 @@ def __init__(

self.text_config = text_config

super().__init__(**kwargs)
super().__init__(tie_word_embeddings=tie_word_embeddings, **kwargs)
Loading