-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Add symbolic function for XSoftmax op for exporting to ONNX. #14013
[ONNX] Add symbolic function for XSoftmax op for exporting to ONNX. #14013
Conversation
Might be of interest to @BigBird01 |
This is cool! Thanks! |
@BigBird01 Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me, thanks for your great contribution!
Quick question: do you plan to add the ONNX DeBERTa export support now that you have added support for the problematic operator?
No, no plan for this yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, LGTM! Thank you @fatcat-z
@fatcat-z Hi, I have a question about the way symbolic conversion is implemented. Is there any reason why you are using |
What does this PR do?
For such customized operator, PyTorch ONNX exporter will try to call its symbolic() function for exporting to ONNX file. Add the implementation here so that it could be exported successfully.