Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/simplify object detection task guide #29964

Closed
3 of 6 tasks
NielsRogge opened this issue Mar 30, 2024 · 6 comments
Closed
3 of 6 tasks

Improve/simplify object detection task guide #29964

NielsRogge opened this issue Mar 30, 2024 · 6 comments
Labels

Comments

@NielsRogge
Copy link
Contributor

NielsRogge commented Mar 30, 2024

Feature request

The object detection task guide has a bunch for issues so it'd be great to solve them.

Motivation

Several people have reported the following issues regarding the object detection task guide:

Moreover, when inspecting the notebook, I saw:

  • there's no GPU leveraged during evaluation
  • the timm dependency is no longer required as you can now pass revision="no_timm". Moreover, Accelerate is a dependency but is not included in the guide
  • the post_process method needs to be updated to post_process_object_detection, passing a threshold of 0 for computing metrics

Your contribution

I could work on this but would be great if someone else could take this up

@rootonchair
Copy link
Contributor

Hi @NielsRogge , do you still need help on this?

@NielsRogge
Copy link
Contributor Author

@rootonchair yes, the first 3 points still need to be addressed. We would need to simplify the evaluation of the model during training

@rootonchair
Copy link
Contributor

Sure, let me work on this

@NielsRogge
Copy link
Contributor Author

Also related: #28893

@g1y5x3
Copy link
Contributor

g1y5x3 commented Apr 29, 2024

image
Here is a training run that I did a while back using the original repo, 10 epochs is roughly around 200k steps in this figure and I doubt the model would give any meaningful predictions at that point. I haven't ran the training through HF's example yet. Will try it to understand the problem better. The problem is just that this model is awfully slow to train even with A100s...

@NielsRogge
Copy link
Contributor Author

Closing as this is now fixed by #30683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants